rallat / effectiveandroid Goto Github PK

View Code? Open in Web Editor NEW

1.7K 1.7K 166.0 649 KB

This sample project shows how to apply MVP and Clean architecture on an Android app

Java 100.00%

effectiveandroid's People

Contributors

Stargazers

Watchers

Forkers

taimur97 vmlinz saady msoftware androidalphabet tuohe edgenit adielr augmify streamride bgogetap yippeeapp cthu rafaeltoledo necritos hsavit1 kingslou htoooth siemnok paradox21 shipan2012 bhavdip xantage nyjsl teddy-lee dotfeng rednels dxiaogang tubb jiyuren youlongzixia wtest afthill haikuowuya tuanhv-0226 haiolv bensonx weikipeng hejunbinlan quangson91 aselims applied-duality amanarora12 blakewl sohail-aziz soyoungboy zxfjd3g jacklam102 gopalk guiguegon alexandru-calinoiu vamsirajendra rowandjj yzp531 aegislee matrixy christofbuechi mkodekar suxinde2009 yszx123 firojdevpoint elevenfive nfirex grmaciel jansonjoan zhy206517 wenzhenxing wangliang7730 collectionbyzcz adhamenaya volcanoscar oliveiradev caramelool shekaroppo bowmanb krishan14sharma carythh mohammed90 tonmoy71 maniacs-m itamaradin15 hckrtst tikitoo huaidong ingjuanpchm arxderong patrickngare dhavaljivani aliceresponde biodunalfet jmortega mqync xiaoshi316 mapleskip nuixy taotaocheng ljl546158733 mafuhua sheeraz1022 black4bird

effectiveandroid's Issues

Clean Architecture query

@rallat Uncle Bob says when you open the package structure, it should scream the intent of the application and not the tools/framework used. Right now the packages model, presenter, service, ui just tell me about the tools, that MVP is used. What's your opinion?

New Logo/Icon

Hi @rallat i am a graphic designer, i want to help others in graphic design.
After i reviewed your project. you have no logo on this project, therefore I want to contribute to this project by creating a new logo/icon. what do you think ? you want it ?

how to resolve the Q : Missing fabric.properties

Error:(19, 0) Missing fabric.properties, check the fabric.properties.sample file.
Open File

Package by feature

This project does not look like it has been packaged by feature. Is that intentional?

Missing fabric.properties, check the fabric.properties.sample file.

Exception is thrown when trying to build the app after cloning.
"fabric.properties.sample" file is missing as well

Missing Fabric.properties

Can not checkout the project on AS Throws the following error

Missing fabric.properties, check the fabric.properties.sample file

2015-10-02 00:14:48,990 [19884657]   WARN - nal.AbstractExternalSystemTask - Missing fabric.properties, check the fabric.properties.sample file. 
com.intellij.openapi.externalSystem.model.LocationAwareExternalSystemException: Missing fabric.properties, check the fabric.properties.sample file.
    at org.jetbrains.plugins.gradle.service.project.AbstractProjectImportErrorHandler.createUserFriendlyError(AbstractProjectImportErrorHandler.java:103)
    at org.jetbrains.plugins.gradle.service.project.BaseProjectImportErrorHandler.getUserFriendlyError(BaseProjectImportErrorHandler.java:158)
    at org.jetbrains.plugins.gradle.service.project.BaseGradleProjectResolverExtension.getUserFriendlyError(BaseGradleProjectResolverExtension.java:438)
    at com.android.tools.idea.gradle.project.AndroidGradleProjectResolver.getUserFriendlyError(AndroidGradleProjectResolver.java:348)
    at org.jetbrains.plugins.gradle.service.project.AbstractProjectResolverExtension.getUserFriendlyError(AbstractProjectResolverExtension.java:164)
    at org.jetbrains.plugins.gradle.service.project.GradleProjectResolver$ProjectConnectionDataNodeFunction.fun(GradleProjectResolver.java:366)
    at org.jetbrains.plugins.gradle.service.project.GradleProjectResolver$ProjectConnectionDataNodeFunction.fun(GradleProjectResolver.java:332)
    at org.jetbrains.plugins.gradle.service.project.GradleExecutionHelper.execute(GradleExecutionHelper.java:225)
    at org.jetbrains.plugins.gradle.service.project.GradleProjectResolver.resolveProjectInfo(GradleProjectResolver.java:97)
    at org.jetbrains.plugins.gradle.service.project.GradleProjectResolver.resolveProjectInfo(GradleProjectResolver.java:65)
    at com.intellij.openapi.externalSystem.service.remote.RemoteExternalSystemProjectResolverImpl$1.produce(RemoteExternalSystemProjectResolverImpl.java:41)
    at com.intellij.openapi.externalSystem.service.remote.RemoteExternalSystemProjectResolverImpl$1.produce(RemoteExternalSystemProjectResolverImpl.java:37)
    at com.intellij.openapi.externalSystem.service.remote.AbstractRemoteExternalSystemService.execute(AbstractRemoteExternalSystemService.java:59)
    at com.intellij.openapi.externalSystem.service.remote.RemoteExternalSystemProjectResolverImpl.resolveProjectInfo(RemoteExternalSystemProjectResolverImpl.java:37)
    at com.intellij.openapi.externalSystem.service.remote.wrapper.ExternalSystemProjectResolverWrapper.resolveProjectInfo(ExternalSystemProjectResolverWrapper.java:49)
    at com.intellij.openapi.externalSystem.service.internal.ExternalSystemResolveProjectTask.doExecute(ExternalSystemResolveProjectTask.java:51)
    at com.intellij.openapi.externalSystem.service.internal.AbstractExternalSystemTask.execute(AbstractExternalSystemTask.java:138)
    at com.intellij.openapi.externalSystem.service.internal.AbstractExternalSystemTask.execute(AbstractExternalSystemTask.java:124)
    at com.intellij.openapi.externalSystem.util.ExternalSystemUtil$4.execute(ExternalSystemUtil.java:540)
    at com.intellij.openapi.externalSystem.util.ExternalSystemUtil$5$1.run(ExternalSystemUtil.java:612)
    at com.intellij.openapi.progress.impl.CoreProgressManager$TaskRunnable.run(CoreProgressManager.java:563)
    at com.intellij.openapi.progress.impl.CoreProgressManager$8.run(CoreProgressManager.java:367)
    at com.intellij.openapi.progress.impl.CoreProgressManager$2.run(CoreProgressManager.java:152)
    at com.intellij.openapi.progress.impl.CoreProgressManager.registerIndicatorAndRun(CoreProgressManager.java:452)
    at com.intellij.openapi.progress.impl.CoreProgressManager.executeProcessUnderProgress(CoreProgressManager.java:402)
    at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:54)
    at com.intellij.openapi.progress.impl.CoreProgressManager.runProcess(CoreProgressManager.java:137)
    at com.intellij.openapi.application.impl.ApplicationImpl$10$1.run(ApplicationImpl.java:617)
    at com.intellij.openapi.application.impl.ApplicationImpl$8.run(ApplicationImpl.java:400)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
    at java.util.concurrent.FutureTask.run(FutureTask.java:262)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
    at java.lang.Thread.run(Thread.java:745)
    at org.jetbrains.ide.PooledThreadExecutor$1$1.run(PooledThreadExecutor.java:56)

Adding Android Data Binding to the Clean branch

I see that the Clean architecture doesn't include Android Data binding with MVVM pattern.

MVVM is really powerfull especially when used it along with Data binding engine, and since Google has implemented this engine, i'm considering to learn the MVVM pattern with data binding in the Presentation layer of the clean architecture.

Persist Articles

mvp with fragments?

Any chance of adding branch that shows how you would handle mvp with fragments?

Presenter State Never Is Saved

I've been reviewing your project seems good but I've been trying and never saves the state of the presenter.

When you save the state using PresenterHolder.getInstance () putPresenter (TopImagesListActivity.class, presenter); works well but I found that when I try to recover the state the task of being saved even then not complete when I get the instance again PresenterHolder.getInstance().getPresenter (TopImagesListPresenter.class); always is null.

Your example

if (presenter != null) {
//This line never is executed
            presenter.setView(this);
        } else {
            presenter = new TopImagesListPresenterImpl(this);
//always is executed
        }
}

Do you have any other alternative that you used?

Thank you for your contribution and your awesome job!

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.

Jobs

Jooble