ramonauble / sp Goto Github PK

mostly minor but i'm a bit of a perfectionist... don't want there to be any ambiguity at all for anyone referencing my code :]

when envelope decay time is at its leftmost (0) or rightmost (1023) parameter boundary, the envelope time will "wrap around" to the opposite boundary

this causes a sudden jump from max decay to min decay, and vice versa, when the decay pot. is moved to the right/leftmost boundaries, respectively

the parameter is likely overflowing at the boundary cases - use serial monitor to debug

by design, if seq length is changed & current seq position exceeds the new maximum, the sequencer is forced to restart;

likewise, if seq length is changed & current seq position is less than or equal to new seq maximum, seq continues as normal

need to add check to only restart seq if it was playing previously... and not restart if it is stopped & the length is changed.