js-nerdery-challenges's People
Forkers
laurajimenezb dianasanchezordonez fran2304 eriverotupac gcoayla lamlemonpie guidotapia starunu lgcaceres userlifex patrick100 templario01 giulianodelagala jo3l17 kcotrinam csagastegui59 juanmdpc marceloev123 statusunknown418 fabiosotodev devmata jainor quebin31 xrls9 cheshire21 aimless397 kevinpc98 jackelinepao victord2 jeanmejia bllerenac aaron-0406 michellepineda90 gabrielnima freddy-bedregal mulberry417 kira56 keviningles2314 dianacalx gerardotamo veraveraniego deeiqh migigim theonlylooker rdev32 smundev alrus2797 eduardosdacr warevil orellanaoc gvillegasc joze01js-nerdery-challenges's Issues
Incorrect unit tests values for `ownPower` and `digitSum`
I noticed that there are some incorrect unit tests for ownPower
and digitSum
. For the former the last test is failing (i.e. ownPower(21, 12)
) because 21 ** 21
is larger than Number.MAX_SAFE_INTEGER
this already creates an overflow, if you don't use a BigInt
from the beginning final sum is obviously going to be bigger than Number.MAX_SAFE_INTEGER
, and for the latter something similar was happening, take for example the factorial of 42, this number is also going to be greater than Number.MAX_SAFE_INTEGER
using number
here is incorrect because it's going to produce an overflow.
>>> MAX_SAFE_INTEGER = 2 ** 53 - 1
>>> 21 ** 21 > MAX_SAFE_INTEGER
True
>>> import math
>>> math.factorial(42) > MAX_SAFE_INTEGER
True
Please refer to #33 for the following:
To prove these points I included a Python3 script (challenge.py) with implementations to those two functions, but with the difference that Python3 supports arbitrarily large numbers out of the box, if you run this script you'll see the correct values.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.