GithubHelp home page GithubHelp logo

embersrekindled's People

Contributors

2z6c avatar aemande123 avatar baka943 avatar bearheathen avatar bigenergy avatar bogger33 avatar cs8minty avatar daedalusgame avatar elucent avatar epicsquid avatar ewanm89 avatar ianlavr avatar ichttt avatar kurtchekov avatar polyacovyury avatar rcxcrafter avatar redfire75369 avatar sskirillss avatar tehnut avatar tth05 avatar upcraftlp avatar yrsegal avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

embersrekindled's Issues

copper cells not working on 1.20.1

the copper cells do not retain the stored ember once broken and become unsuable after being placed once more
only other mods instaled are embeddium and embeddium +++
modernfix and ferrite core and jei almost forgot that one

Archaic brick recipe bug(?)

When you try to craft archaic bricks with more than 1 archaic brick on exchange table the result is not added to the total number of bricks on exchange table.

To recreate it follow this steps:

  1. Try to craft archaic bricks. At the end of process there will be 5 bricks on the table.
  2. Do not take the result and start crafting process again.
  3. At the end there will be the same amount of bricks. Another ingridients was consumed as usual.

Ancient ruins spawn in the middle of the ocean

If an instance has both Embers and a mod that lowers terrain height like Tectonic, the ancient ruins will spawn floating in the middle of the ocean. Not a huge problem, but it looks kind of ugly. It could be fixed if a config option was added for the max height of the ruins. That would be pretty RAD of you. ;)

[Suggestion] Re-add Gear Stamp

In 1.12.2, Embers had a gear stamp, to allow making gears in the stamper. This stamp doesn't exist in the 1.20.1 version. It would be nice to have it again, I think.

Feature Request: Config Option for Metal Seeds Recipe

Glad to see this being ported to newer versions, but I really don't like the change that metal seeds must be found in loot. I love Embers primarily because you don't need to grind much of anything just to use the mod's features, and forcing players to go out and find them in loot kinda goes against that. They weren't very powerful to begin with unless you had a lot of time on your hands, so I don't really think they deserve this nerf personally.

Stamping recipes always result in Embers plates

Unsure if this is a KubeJS, AlmostUnified, or Embers issue, but with Create having a higher priority in AlmostUnified, or even a custom kubejs recipe replacing yours with the same #forge:plates/copper, the result is always an Embers plate. I made sure items are tagged correctly.

embersrekindled-1.20.1-1.0.2.jar
almostunified-forge-1.20.1-0.7.0.jar
kubejs-forge-2001.6.3-build.83.jar
create-1.20.1-0.5.1.f.jar

It seems like iron and copper sheets are the only two affected, electrum from createadditions works, as well as Create's gold sheets.

JEI Not Showing Custom Recipes 1.20.1 Base Forge

Adding Custom recipes Using Crafttweaker Json system for the mixer and removing the base recipe for what i added, yet what i changed is not showing up in JEI

On top of this i noted that using /reloaded breaks this mods JEI intergration all together some times

Reporting as bug and hope for way to fix as using this in as expert sytle pack, were the mods planned to be used heavly late game

Exchange tablets and alchemy pedestals allow taking items from them during crafting

Exchange tablets and alchemy pedestals allow taking items from them during crafting and don't stop the recipe. If you take all ingredients - it will crash and break world (unable to load it again)
2024-04-14_12 09 15
Crash error:

Description: Ticking block entity

java.lang.IllegalArgumentException: bound must be positive
	at java.util.Random.nextInt(Random.java:322) ~[?:?] {}
	at com.rekindled.embers.blockentity.AlchemyTabletBlockEntity.clientTick(AlchemyTabletBlockEntity.java:179) ~[embersrekindled-1.20.1-1.1.1.jar%23352!/:1.20.1-1.1.1] {re:classloading}
	at net.minecraft.world.level.chunk.LevelChunk$BoundTickingBlockEntity.m_142224_(LevelChunk.java:689) ~[client-1.20.1-20230612.114412-srg.jar%23444!/:?] {re:classloading}
	at net.minecraft.world.level.chunk.LevelChunk$RebindableTickingBlockEntityWrapper.m_142224_(LevelChunk.java:782) ~[client-1.20.1-20230612.114412-srg.jar%23444!/:?] {re:classloading}
	at net.minecraft.world.level.Level.m_46463_(Level.java:468)

KubeJS failing on first run

When starting up the game, KubeJS runs into a null pointer exception (stacktrace) in the StampingRecipe.getResultItem function.

Running a /reload command causes things to work properly.

Using:
Embers Rekindled 1.20.1-1.1.0
NeoForge 47.1.84
KubeJS 2001.6.4-build.114

Camenit level bug

I do not know, but for some reason all mechanisms and machines except camenit level are completely streamlined, that is, water can be poured into them.

(1.20.1) Pipe models are incompatible with ModernFix's Dynamic Resources

Log with relevant error
Crash report (this crash isn't consistent - not really sure what's going on here)

Dynamic Resources is a config option for ModernFix that significantly reduces ram usage. It's incompatible with baked models, which seems to be what Embers uses for pipe models.

I'm not able to reproduce the crash and resource fail at all with only Embers and ModernFix, but the pipe model is definitely not rendering properly at the very least.

Bins create shadow items

With /fill, bins can pick up the same item and show and hold them in each bin at the same time.

If you interact with one of the items in any normal way, any shadow items of it will vanish (however, this is just what happens with shadow items normally in vanilla).

Several Empty Tags by Default

There are several Dawstone Avil tags that are empty and have no items by default which results in barrier item recipes.

Empty tag: embers:augmentables
Empty tag: embers/augmentables/armors
Empty tag: embers/augmentables/armors/helmets
Empty tag: aether:flaming_reparing
Empty tag: aether:lightning_reparing
Empty tag: aether:holy_reparing
Empty tag: aether:vampire_reparing
Empty tag: aether:pig_slayer_reparing
Empty tag: aether:hammer_of_kingbdogz_reparing
Empty tag: aether:neptune_reparing
Empty tag: aether:phoenix_reparing
Empty tag: aether:sentry_reparing
Empty tag: forge:gems/black_opal
Empty tag: forge:ingots/invar
Empty tag: forge:ingots/mythril
Empty tag: forge:ingots/oynx
Empty tag: forge:ingots/thyrium
Empty tag: forge:ingots/sinisite
Empty tag: forge:ingots/enderite
Empty tag: forge:ingots/osmium
Empty tag: forge:ingots/refinded_glowstone
Empty tag: forge:ingots/refinded_obsidan
Empty tag: forge:ingots/obsidan_infused_enderite
Empty tag: forge:gems/large_amethyst
Empty tag: forge:ingots/stellium
Empty tag: ancitent_aether:valkyrum_reparing

Fails to load on dedicated server neoforge 1.20.1

Server fails to start with embersrekindled-1.20.1-1.2.0 installed giving the following error:
java.lang.BootstrapMethodError: java.lang.RuntimeException: Attempted to load class net/minecraft/client/player/LocalPlayer for invalid dist DEDICATED_SERVER

item dials not displaying create vault items

So i try to use item dials on create mod vaults to see the items inside but when i fill all spaces in the vault with spruce planks the dial still display all slots as NONE. Is this a bug or did i miss something

Problem to add recipes to Mixing centrifuge 1.20.1

I would like to add a recipe with the centrifugal mixing in 1.20.1 through the modification of recipes kubejs

{
  "type": "embers:mixing",
  "inputs": [
    {
      "amount": 2,
      "tag": "forge:molten_copper"
    },
    {
      "amount": 2,
      "fluid": "create_wt:molten_zinc"
    }
  ],
  "output": {
    "amount": 4,
    "fluid": "create_wt:molten_brass"
  }
}

or through recipes in kubejs.

ServerEvents.recipes(event => {
    event.custom({
        type: 'embers:mixing',
        inputs: [
            {
                "amount": 2,
                "tag": "forge:molten_copper"
            },
            {
                "amount": 2,
                "fluid": "create_wt:molten_zinc"
            }
        ],
        result: { "fluid": 'embers:molten_dawnstone', "amount": 4 },
    })
})
```js

but it doesn’t work 

Fluid tags don't include flowing variants of the fluids

Vanilla's water and lava tags include the flowing state of the fluid, not just the source. Embers doesn't.
Could be a design decision of course, but if someone were to build something that triggered based on presence of a certain fluid, only the source blocks would trigger it, which seems undesired, especially with the fact most of the fluids are added to Forge tags and not specifically Embers tags.

ore blocks such as gold or diamods had their required tool tier changed

not sure why you would change that, but it appears that ores such as gold and diamonds had their required tool tier changed from iron to diamond. this means that i need a diamond pickaxe to mine diamonds, and i assume this isn't a feature. additionally, when paired with the mod oreganized, an electrum ingot from that mod can be created for way cheaper because of the stamping crafting. when a nugget stamp is used, an ingot of electrum is produced instead of a nugget

[Suggestion] Molten Steel

Addition of steel items (molten, seed, recipes for gear and plate, etc...) would be nice for compatibility with mods such as Immersive Engineering and Railcraft.

Ability to control ember deposits in the world

Hi. Would be cool to be able to control if certain dimension/biome contains ember. For example, if modpack maker wants to disable ember on the moon. Or maybe even control how much ember certain biome/dimension could contain

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.