rdswift / picard-scripts Goto Github PK

hi, sorry to bombard you with so many PRs and issues this morning. first of all, thanks so much for your script, i've been using it with minimal edits for several years and it's straight up the only way i'd ever keep my library organized.

my issue pertains to, i think, this section of the script

$if($eq(%_nAlbumType%,Standard),$if($eq($if2(%musicbrainz_albumartistid%,%_cVariousArtistID%),%_cVariousArtistID%),
    $set(_nFilePath,%_cVariousArtist%/%_nYear% %_nANT%/),
    $if($eq($if2(%musicbrainz_albumartistid%,%_cUnknownArtistID%),%_cUnknownArtistID%),
        $set(_nFilePath,%_cUnknownArtist%/%_nYear% %_nANT%/),
        $set(_nFilePath,%_nInitial%/$if(%_aNoArtistSort%,%_nFAA%,%_nFAAPS%)/%_nYear% %_nANT%/)
)))

my understanding of this logic is:

check if the musicbrainz_albumartistid is available, if not grab the various artists ID constant
if neither the album artist id or the various artists ID constant are empty, set the path to use [Various Artists]
otherwise similar logic for setting the path to use [Unknown Artist] or the file path initials depending on user settings

but if i understand correctly, there are two issues here that are i think causing some problems with my files.

the first is that since cVariousArtistID is never empty since it is set in the file (i guess this check may be for robustness?), a file without the musicbrainz_albumartistid tag will always be set to Various Artists. afaiu the unknown artist logic never gets hit

the second is that i don't believe i follow the logic for treating the release as various artists because the artist ID isn't filled. i guess it is written this way as a failsafe in case MB doesn't have the album, because if it did, the tags would already be filled, but i think maybe it would be better to put this

either way in my experience albums that aren't on MB get sorted as Various Artists, and in tandem with the soundtracks issue i described in #5 , my non-MB soundtracks will get thrown into Various Artists and will have the solo artist of the album listed in the filename in [Brackets] as if they were different from the main album artist