Is the bot running correctly? about translations.react.dev

[carburo]

@gaearon What's the current status of this? We've updated the Spanish maintainer's list, but that doesn't seem to trigger any updates.

[bvaughn]

Honestly I don't know. I thought I had setup GH actions for the permissions specifically because that seemed like a security concern. I don't have access to notes (or even the actions or org settings anymore) to confirm that or to jog my memory though, and it's been years.

You probably have more context than I do at this point regarding what makes the most sense.

[gaearon]

cc @bvaughn I remember we moved the script out of Nat's Heroku instance but I can't find where we documented the new setup... Do you have access to this?

[bvaughn]

@gaearon I wrote a pretty detailed post in the React team Workplace (which I'd link to, but I don't have access to it anymore) describing the new workflow (when things run, how to add a new project, etc).

The sync script code is here: https://github.com/reactjs/reactjs-translation-sync-script

IIR it's pulling language list from this directory: https://github.com/reactjs/reactjs.org-translation/tree/main/langs

[gaearon]

ahhh ok

[bvaughn]

It's possible the script has since stopped working (maybe a token has expired or something?) Haven't thought about the script in several months.

[gaearon]

Hmm, is the sync script responsible for granting repo permissions? I'm looking at it now but I think it's only sending PRs. There's something else that's supposed to grant repo permissions. I'll find your post after breakfast..

[gaearon]

To clarify, the problem isn't with the sync but with creating a fork automatically and updating translation maintainers

[bvaughn]

I don't remember but I think there may have been a manual step involved. I'd have to re-read my old notes (post)

[gaearon]

@bvaughn Re-reading your post, it's entirely concerned with translation content syncing. All the logic for the permission syncing is still in this repo. I presume it was never hooked up to GH Actions, which is why it stopped working the moment Heroku was disconnected.

[bvaughn]

@gaearon I can believe it. It's been years since I've been involved with this and I don't even have access to my old notes or the post you're talking about.

[gaearon]

OK that makes sense. Do you remember if there's any reason this repo has permissions set to everyone? I was thinking of moving the syncing script back, but removing permissions for everyone except org admins. So we'd review the maintainer change requests (which are rare), but the script would be public. Does this make sense?

[gaearon]

@mirorauhala Apologies for this — our bad. (We were already working on the new site so didn't feel like this was urgent.) We're fixing this soon: #285

[gaearon]

Fixed by #285.

[gaearon]

reactjs/fi.react.dev#1