GithubHelp home page GithubHelp logo

r2-lcp-kotlin's People

Contributors

aferditamuriqi avatar idmostapha avatar mickael-menu avatar pavelric avatar qnga avatar stevenzeck avatar twaddington avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

r2-lcp-kotlin's Issues

Webpage not available

Error messages when opening/closing an LCP protected ebook (may be an application issue).

On Android 9

Steps:

  • open an LCP protected epub; sometime the "Webpage not available page" appears. Swiping removes the message.
  • close an LCP protected epub; the "Webpage not available page" appears.

Screenshot_20190927-163600

Build error caused by the package named `public`

We're facing an issue while trying to use the classes from org.readium.r2.lcp.public (imported as a submodule). The build is failing with this error:

e: java.lang.IllegalStateException: failed to analyze: java.lang.IllegalStateException: processingEnv must not be null

https://stackoverflow.com/a/59530688

If we rename the public package in r2-lcp-kotlin, the error disappears.
The weird thing is that this problem doesn't occur in r2-testapp-kotlin. Do you have any insights into why @aferditamuriqi?

Regardless of this build error, I think the classes in public should be moved to the top-level package anyway.

Logical error on rights validity check

The function areRightsValid() throws an exception when the current date is in the loan date range instead of allowing the user to import/open the book

Publication on External storage

Hi!

I noticed that the a publication is saved in the external storage in fetchPublication ( r2-lcp/src/main/java/org/readium/r2/lcp/license/License.kt). My thought is that internal storage is better because then the files are removed when the app is uninstalled. What are the benefits of storing publications on external storage?

Would it be possible to set the rootDir in the constructor, or should i just move the publication from external to internal after it is fetched?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.