GithubHelp home page GithubHelp logo

Comments (6)

danielweck avatar danielweck commented on August 25, 2024

Thank you for reporting this. We must review the algorithm and we could even make an decision based on that alone (assuming we find some obvious arithmetic error). But ideally we should also be able to reproduce the bug, if possible with the cloud reader so we can link to it. Do you have suggestions as to: which EPUB, which viewport dimensions? (etc.)

from readium-shared-js.

jplaitin avatar jplaitin commented on August 25, 2024

Any book with innerlinks that aren't at start of the spine should work if you change font size a bit. Link should point at the end of a page (this should cause that round up "error" to happen) and spine should be split to multiple pages.

from readium-shared-js.

danielweck avatar danielweck commented on August 25, 2024

@jccr have you experienced this bug?

from readium-shared-js.

jccr avatar jccr commented on August 25, 2024

@danielweck @jplaitin
I'm looking into this.
Thanks for the report.

from readium-shared-js.

jccr avatar jccr commented on August 25, 2024

2000 years later

I can confirm the change to Math.floor from Math.round fixes this regression.
Thanks for the report @jplaitin

from readium-shared-js.

danielweck avatar danielweck commented on August 25, 2024

Closed via #444

from readium-shared-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.