GithubHelp home page GithubHelp logo

Highlights about readium-shared-js HOT 1 CLOSED

DougsAraujo avatar DougsAraujo commented on June 28, 2024
Highlights

from readium-shared-js.

Comments (1)

danielweck avatar danielweck commented on June 28, 2024

In the develop branch (which will be merged into master at the next official tagged release), plugins/highlights was removed by this Pull Request: #446

The team of core contributors recently agreed to remove the out-of-date highlights plugin. This experimental "annotation" code was relying on Rangy (or to be precise: a fork of it tweaked by @jccr, the original plugin implementer). Rangy was causing problems in the build system (see #445 ), and as the core Readium projects (Chrome app, cloud reader, native apps, etc.) do no make use of the functionality provided by the highlights plugin, it was decided to simplify the codebase and build system by removing both Rangy and the highlights plugin (note that Rangy was also used in a few other places, notably for an experimental / unused Media Overlays feature).

So, you can re-instate plugins/highlights and Rangy in your own fork, by simply reverting the git commits (git revert) in the following PRs:
#446
readium/readium-js#190
readium/readium-js-viewer#695

from readium-shared-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.