Comments (15)
As far as I can see that's probably the best way. I'd also add a link in this description of your fork to the one in the org, since initially at least yours will have higher Google power than the org, so people are likely to find it first.
I'll go ahead and destroy the existing repo in the reagent-project, since I don't think it serves a purpose anymore, and we can do the move whenever your comfortable, unless @yogthos or @seancorfield have something to add.
from reagent.
Yes, a prominent link in README.md to the reagent-project repo should do the trick, I think. Anyway, Github will say "forked from reagent-project/reagent", if I'm not mistaken.
from reagent.
Yes, that's what I've done when I've moved projects under new organizations. Also turn off the wiki and issues in the forked-back repo so that folks don't read outdated docs or mistakenly open issues on the fork instead of the new, main repo.
from reagent.
@holmsand @Whoops @seancorfield just wanted to touch base with you guys to see if we're ready to move the project over. It sounds like the plan is to transfer it over to reagent-project and then we should probably make a release from there with the updates for React 0.12. Any chance we could get that going this week or the next?
from reagent.
@yogthos Sure, if it's ok with everyone, I can move the project over tomorrow. I'll also merge the 0.12 branch into master, so that people can do some testing with that before release (perhaps we should have some kind of half-formal release procedure?).
I think I'll start of with keeping the doc site where it is for the time being (until the future of the org's site is clearer), except that I'll change the links to the project to its new location. I (not surprisingly, perhaps) think that the current site is quite good, except that it obviously needs more documentation (and perhaps some links to users, related projects etc.).
The advantages of the current site are (in my head):
- it's easy to add live examples, since everything is built with Reagent already
- it's quite fast, both on first load (since every page is pre-rendered using node.js), and subsequently (since it is all Reagent)
- it exists :)
The main disadvantage is probably that it seems to be hard for other people to modify :)
If you guys agree, I could start on improving the site by adding some docs for reagent.core, and write a little guide on how it all works.
from reagent.
π
from reagent.
@holmsand sounds excellent. I can help testing against 0.12 once you've got it moved over then. Having some sort of a release process would probably be a good idea, @seancorfield might have the most experience in that department? :)
I definitely agree that the current docs page is excellent. It's very clear and easy to follow, while describing all the major aspects of Reagent. It does a great job of communicating what makes Reagent so fantastic to work with. :)
One thing we could probably do is add instructions how to create a new project from the template, so people can easily follow along.
Aside from that, I my vote would be to keep the existing page as is and then have a separate site for detailed documentation, tutorials, etc.
from reagent.
I'd just recommend publishing an 0.4.4-beta for testing (since we already had an 0.4.4-alpha from @Whoops repo) and leave that out there for a while (a month?), and then do a full 0.4.4 release.
from reagent.
that sounds like a solid plan :)
from reagent.
Ok, so now the project is reagent-project/reagent!
Welcome everyone to the brand new world of org-based reagent-ing!
from reagent.
Woohoo!!! Thank you @holmsand !
from reagent.
exciting times ahead :)
from reagent.
π exciting indeed!
from reagent.
Looks like this can be closed out as completed?
from reagent.
Looks that way :)
from reagent.
Related Issues (20)
- Reaction value propagation glitch - the dirty flag is not set HOT 3
- Bad react key warning when using false as key
- examples/material-ui not work HOT 1
- examples/material-ui not work HOT 1
- Docs on βChanged?β inaccurate? HOT 5
- React 18 does not live reload with Shadow-CLJS in non-trivial projects HOT 5
- Prop types
- `TypeError` when using function components with `r/create-class` with `dom.server/render-to-string`
- ReactDOM.render is no longer supported in React 18. Use createRoot instead. HOT 2
- shadow-cljs emits a warning when using with-let HOT 4
- Korean input broken on :input and :textarea HOT 1
- Update docs? HOT 1
- MUI ThemeProvider not working HOT 1
- @@ -62,6 +62,45 @@ class _Config { } } // eslint-disable-next-line valid-jsdoc /** * fetch problem title, level via solved.ac api * @see {@link https://solvedac.github.io/unofficial-documentation/#/operations/getProblemByIdArray} * @param {string[]} pids - list of problem id (up to 100) * @param { ({ problemId, titleKo, level }) => void } callback */ function fetchProblemsFromSolvedAc(pids, callback) { const query = encodeURIComponent(pids.join(',')); console.log(`https://solved.ac/api/v3/problem/lookup?problemIds=${query}`); fetch(`https://solved.ac/api/v3/problem/lookup?problemIds=${query}`) .then((res) => { console.log('fetchProblemsFromSolvedAc', res); return res; }) .then((res) => res.json()) .then(callback) .catch(() => callback(null)); }
- Readme says npm i or add deps to .edn but (in my case at least) needed both HOT 1
- Any interest in being able to replace `react/createElement` with a custom function? HOT 7
- The cursor disappears at the end of a controlled input on Chrome
- Reusable components following HTML semantics of Opional Attributes and Variadic Children HOT 3
- Controlled input loses cursor under ShadowRoot in React 18 HOT 3
- snake_case mentioned instead kebab-case in documentation of create-class function.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reagent.