rebassjs / rebassjs.org Goto Github PK

Continuing the discussion from rebassjs/rebass#584:

As per feedback in this issue and inspired by the current npm scripts, I will use a combination of repng, scrs --svg and potentially other libraries such as png-to-ico to generate the necessary files. For the start, we can probably stick with:

1. a 48x48 or 32x32 ico
2. a larger png
3. an Apple Touch icon (need to automate editing the icon for this?)

Original text for clarity and searchability:

Hi, first of all, thanks for this project!

It would be nice to have a favicon to identify the tabs when no titles are shown (see screenshot below). It looks like the docs are being built with gx, but I didn't see on first glance where a PR would be made for a favicon.

Maybe an option would be a monochrome / adapted version of the logo image?

the favicon.ico isn't loading onto the website, the browser console is giving out a 404 error for the same.
could be an intentional reason as there seems to be some work going on with the favicon but if it isn't would love to investigate and solve this issue and send up a PR.

Screenshot:

I made a small update on the docs which i'd like to share with you. Can you add me as a contributor so i can make a branch for my updates and open a pull request?