recillah-khamala / recillah-khamala-portfolio

Project Name

Portfolio: setup and mobile version skeleton - For this project, I use CSS and HTML skills learned to build this website a duplicate of an already provided template.

Built With

• HTML/CSS

Live Demo (if available)

Live Demo Link

Getting Started

This project assigned by microverse, goes on to showcase all the projects I have done and the languages they are written on.

To get a local copy up and running follow these simple example steps.

Setup

Get to this repisitory by choosing Recilla-Khamala-Portfolio repository in github and clone to your device. (https://docs.github.com/en/repositories/creating-and-managing-repositories/cloning-a-repository) This documentation details the steps to take to clone a repository.

Authors

👤 Author1

• GitHub: [@Rn486]https://github.com/Rn486)
• Twitter: @recillahk
• LinkedIn: LinkedIn

🤝 Contributing

Contributions, issues, and feature requests are welcome!

Feel free to check the issues page.

Show your support

Give a ⭐️ if you like this project!

Acknowledgments

• Much thanks to Microverse.
• Grateful to figma for providing the template.

📝 License

This project is MIT licensed.

recillah-khamala-portfolio's Issues

Morning session code review with coding partners

Great work done so far, the design is elegant and expressive with fonts properly formatted. Just a few additions and adjustments as observed and listed below:

• The form section is not aligned correctly and formated. You could try to resize the form so to fit the template design from Figma.
• Your linters check failed for this commit, so you could rerun the tests locally to confirm you fixed the errors before pushing again.

Bugs in the javascript code

Hi Recillah! Kudos for coming so far in your project, I found some bugs in your javascript file that might cause some trouble. I came up with the solution too! These are all from your popup-window branch in your pwindow.js file

Suggested changes
-In line 60, you wrote this tag.classList.add(tech) , I recommend you add single quotes to tech, like this ('tech') in order to create the class, do this for the rest of the other classes you are trying to create.
-In lines 59 and 107, you used the URL interface incorrectly, you wrote URL.append(tag). The URL interface is used to parse, construct, normalize, and encode URLs. Please use it like this URL('url').
-This is for best practice, please add semicolon at the end of all your functions, variables etc.
-Last but not least, I see you were trying to loop through your tdetail array with the for each method. I suggest you use this format array.forEach((element, index, array)...rather than array.element.forEach(element, index, array)

All the best with your project!