redhat-sap / molecule.driver Goto Github PK

When creating data disks second time (idempotency) if there is any data exists already on managed disk, creation failing with following error

"
TASK [Create logical volume] ***************************************************
fatal: [localhost -> unpack(4.231.231.107)]: FAILED! => {"changed": false, "msg": "Sorry, no shrinking of lv-lun0 to 0 permitted."}
"

Whole disk becomes not working on OS level

"ls: cannot access 'sap': Input/output error"

ls -al gives
" ? d?????????? ? ? ? ? ? sap"

Then resource group is created in instance_create.yml it is create in the same region (location) as indicated in molecule.yml.

This is not correct behaviour if resource group already exists in another region. Azure allows to put resources from another regions to resource group. So code should just check if resource group is created, and then use that resource group for all created resources, and not force other resources to be created in the same region, if resource group already exists.

See discussion in the comment.

Originally posted by @gciavarrini in #17 (comment)

Dependency section has to be removed to avoid replacing collection locally when developing.

creation of data_disks fails, resourcegroup_name undefined, default resource group name should be used in that case

Here is error message

"
fatal: [localhost]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'resourcegroup_name'\n\nThe error appears to be in '/Users/ksatarin/.ansible/collections/ansible_collections/molecule/driver/playbooks/azure/tasks/create_managed_disk.yml': line 15, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Create managed disk\n ^ here\n"}
"

add rescue section to create playbook so if instances are created and IPs are available they will be saved in molecule inventory and molecule login will work

See documentation

https://docs.ansible.com/ansible/latest/collections/azure/azcollection/azure_rm_resource_module.html#ansible-collections-azure-azcollection-azure-rm-resource-module

That might be used for
ANF
managed disks v2
shared storage with NFS
etc

There is the need to sync the version in galaxy.yml and the version used in install target of Makefile.

If galaxy.yml has version: 0.2.0 and make install is

install: build
	ansible-galaxy collection install --force molecule-driver-0.1.0.tar.gz

when executing make install command, the following error is generated:

 ansible-galaxy collection build --force
Created collection for molecule.driver at /home/runner/work/molecule.driver/molecule.driver/molecule.driver/molecule-driver-0.2.0.tar.gz
ansible-galaxy collection install --force molecule-driver-0.1.0.tar.gz
ERROR! Neither the collection requirement entry key 'name', nor 'source' point to a concrete resolvable collection artifact. Also 'name' is not an FQCN. A valid collection name must be in the format <namespace>.<collection>. Please make sure that the namespace and the collection name contain characters from [a-zA-Z0-9_] only.

Could not find molecule-driver-0.1.0.tar.gz.
make: *** [Makefile:17: install] Error 1

Managed disks V2 is very important use case for SAP customers, MSFT expect a lot of customers migrate from ANF (Azure NetApp Files) to managed disks V2