Comments (12)
Hi Dan, back when things were flat just needed the app id and we could get rolling.
Now that things are in sections and apps are more intertwined its complicated.
I want to ask here so I dont make assumptions and have to follow up again.
Can you take a look at the guesses I made and correct me if Im wrong?
Settings
Catalog Sources
href = /hybrid/settings/catalog-sources
app = the sources application?
Cost Management Sources
href = /hybrid/settings/cost-management-sources
app = cost-management aka koku-ui?
from insights-chrome.
That looks good to me. Will update our router to match. Thank you!
from insights-chrome.
We really need this. Can we please speed this up?
from insights-chrome.
Sergio, please be patient. This is on our radar, but not in the current sprint.
We are working hard to get production working.
from insights-chrome.
Looking at index_map.json and hybrid/settings/cost-management-sources
has the same "real_path" as hybrid/cost-management
. Shouldn't the "real_path" be cost-management/sources
?
{ "req_path": "hybrid/settings/cost-management-sources", "real_path": "cost-management" },
...
{ "req_path": "hybrid/cost-management", "real_path": "cost-management" },
from insights-chrome.
I don't think so real_path is really synonymous with appid at the moment. It's possible that there would be a reason to not have it this way. If some repo housed two apps. With two separate entry point index.htmls... did you all specifically setup cost this way?
from insights-chrome.
Just looked at the koku-ui source and it doesn't seem to be setup as two different apps with two different index.htmls.... thus I think this config is correct. Happy to change if I am wrong but it will break things if we do it and we don't need to
from insights-chrome.
Currently, the route in the Cost management is /sources
, but should that be /cost-management-sources
? It's not clear how hybrid/settings/cost-management-sources
maps to any page in Cost management
from insights-chrome.
Cost Management Sources
href = /hybrid/settings/cost-management-sources
app = cost-management aka koku-ui?
That looks good to me. Will update our router to match. Thank you!
I dont get it. I asked, you acked. What do you want the public URL to be?
/hybrid/settings/_____
I would persuade you away from choosing
/hybrid/settings/sources as there are multiple applications at /hybrid/settings that let you configure sources.
@chargio can you please choose a public URL at which you wish for this application to be exposed? It seems like there is some debate here as to what it should be.
from insights-chrome.
Sorry, I'm not necessarily concerned with the name of the public URL. I'm just trying to figure out what our router path needs to be in order for that link to land on the Cost Management sources page?
I have tried changing our router to match /cost-management-sources. For kicks, I also tried other combinations, like /settings/cost-management-sources -- not that I expected that to work.
Maybe there is a misunderstanding on my end? However, I don't see my router break point being hit at all when clicking that link.
Could this just be an issue with our spandx config?
from insights-chrome.
Sorry, I'm not necessarily concerned with the name of the public URL. I'm just trying to figure out what our router path needs to be in order for that link to land on the Cost Management sources page?
I understand but we (my team) absolutely needs to know these details.
I have tried changing our router to match /cost-management-sources. For kicks, I also tried other combinations, like /settings/cost-management-sources -- not that I expected that to work.
Maybe there is a misunderstanding on my end? However, I don't see my router break point being hit at all when clicking that link.
So the way this stuff works is your index.html is basically the loader and thus entry point for your entire application. All of an applications resources exist in /apps/$appname/* and we configure proxy "magic" to ensure that the human usable paths (like /hybrid/foo/bar/*) always serve up your apps entry point or index.html.
Could this just be an issue with our spandx config?
In development insights-proxy is your proxy to the app so yeah you have to configure net new paths there ... if they are not a subpath of an existing path you'll need to add it.
The best example of this stuff is here:
https://github.com/RedHatInsights/insights-frontend-starter-app/blob/master/profiles/local-frontend.js
In the starter app example for a new path like /hybrid/settings/foo-bar-baz ... you can just add:
routes[`/beta/${SECTION}/settings/foo-bar-baz`] = { host: 'http://localhost:8002' };
routes[`/${SECTION}/settings/foo-bar-baz`] = { host: 'http://localhost:8002' };
I strongly recommend getting a few of these config that do various things - one for local frontend, one for local frontend and api, etc - and committing them to your repo so other team members to share.
I have some time booked for us Monday, if there is still any confusion lets chat about it there. Should be super simple once you've seen it once.
from insights-chrome.
Closing due to staleness, if you have another issue with nav, please open it in cloud-services-config
from insights-chrome.
Related Issues (20)
- Login page does not load on ci-beta HOT 3
- Minified react error at /beta/security/insights HOT 1
- Product Docs, infinite load of chrome and component HOT 4
- AsyncComponent usage example
- Page drawer implementation enhancement HOT 3
- A11y errors caused by incorrect landmark elements in page structure HOT 1
- Help and Settings menus do not have discernible text for screen readers
- getToken() returns empty tokens HOT 8
- The chrome.auth.getToken() should wait for the jwt initPromise like the getUser() HOT 10
- Page breaks when clicking manifests link on side nav after manifests page has loaded HOT 2
- keyboard accessibility: Tab iterates over part of left navigation even when hidden HOT 3
- Question: what's the suggested strategy to deal with @patternfly versions? HOT 4
- Create test script for build vs regular one HOT 1
- getOfflineToken fails if there is a URL param HOT 12
- Analytics: isProd check includes local dev env URL HOT 6
- build fails on Fedora 36 with ERR_OSSL_EVP_UNSUPPORTED HOT 2
- setPageMetadata metadata on first page load HOT 5
- Kiota headers get garbled HOT 2
- RTK Query mutation/POST request headers are missing HOT 3
- Getting a 403 on https://console.redhat.com/openshift/overview/rosa/hands-on/ HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from insights-chrome.