redsiege / edd Goto Github PK

Hello,
You get DomainName parameter in line 22 for "GetDomainGroupSID" function. But I think it is wrong!
https://github.com/FortyNorthSecurity/EDD/blob/82aa4da15adb29ea5f8a6bdb6833bf31ff5e54db/EDD/Functions/GetDomainGroupSid.cs#L22 According to the GetDomainGroupSID function definition this function expects GroupName not DomainName!
https://github.com/FortyNorthSecurity/EDD/blob/82aa4da15adb29ea5f8a6bdb6833bf31ff5e54db/EDD/Amass.cs#L79 As a result function return "Could not find domain group" error always!

Hi, This is a simple problem.
You said in readme, the GetDomainSid function by default takes current domain if no domain is provided. But we should specify domain name for using. I also check in code, it checks providing domain really.

You said in readme the GetSidData function return domain, group and users name from sid (GetSidData exists in both Forest/Domain Information and User Information). but it just work fine for user's sid. And for domain return error meesage.

hello thank u for tool.. tool does not provide samaccountname when using getdomainusers function and puts out first name and last name instead.

thank u