GithubHelp home page GithubHelp logo

Comments (8)

reed avatar reed commented on July 18, 2024

If you change this:

<script src="//www.google.com/jsapi"></script>

to this:

<script src="https://www.google.com/jsapi"></script>

Does it work?

from turbolinks-compatibility.

harmdewit avatar harmdewit commented on July 18, 2024

Unfortunately no, the page still loads the an insecure iframe from a source without https.

from turbolinks-compatibility.

reed avatar reed commented on July 18, 2024

Hey @guangnan, do you have any insight on this?

from turbolinks-compatibility.

chengguangnan avatar chengguangnan commented on July 18, 2024

Sorry. I have no idea.

from turbolinks-compatibility.

jgeggatt avatar jgeggatt commented on July 18, 2024

It doesn't look like there's been any movement on this issue recently, but I would love to try to help find a solution. We are currently having the unfortunate discussion of disabling Turbolinks altogether since we can find no other way around this issue. I have spent some time researching, but have been unable to find any sort of documentation on the Google "Ads" API. I'm thinking there has to be some way to tell it to load a secure ad, either via an options parameter or perhaps by overwriting some loader code. So my question is, what were you guys working off of when you built this code? Any sort of API documentation that exists out there, or was this proprietary knowledge of Google's (publically unsupported) Ads API?

from turbolinks-compatibility.

harmdewit avatar harmdewit commented on July 18, 2024

Unfortunately we did not find a solution and decided to disable Turbolinks. I believe all ads were loading on first visit, but subsequent pages loaded irregularly. Sometimes some ads loaded, sometimes they didn't.

The last thing i can remember is that we didn't have control over our AdWords account and that we were probably using a third party provider besides Google. Maybe they only partially supported loading ads over SSL. Due to time constraints we chose the easy way and dropped Turbolinks sacrificing our loading speed.

from turbolinks-compatibility.

jgeggatt avatar jgeggatt commented on July 18, 2024

@harmdewit that is sad to hear and I'm hoping it doesn't come to that for our project as well. Really, this should be a simple problem to solve (on Google's end) but it doesn't seem that they have any intentions of making this API "supported" any time soon. But then again, I can't find any real mention of this functionality on their site or elsewhere, so maybe I am just looking in the wrong places.

Also, this isn't an issue of AdSense not supporting ads over SSL - they do it as expected when displaying the ads in the suggested manner (ie, without turbolinks). So it is just a bug in the jsapi that is causing the ad to load insecurely.

from turbolinks-compatibility.

pratap224 avatar pratap224 commented on July 18, 2024

hai please help me i am facing problem with turbolinks it is not allowing my ads i followed this link but no use please help me turbolinks/turbolinks-classic#151

from turbolinks-compatibility.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.