reef-technologies / django-subscriptions-rt Goto Github PK

I think the idea to have provider_transaction_id and metadata fields is bullshit, implemented by Alex.

• for apple, all is fine
• for paddle, provider_transaction_id is None until webhook arrives
• for google, there is no unique transaction id, there's only "purchase token" which is same for all subsequent payments

So instead of having "general" provider_transaction_id and trying to make it fit each case, each provider should have its own provider-specific model containing all metadata, i.e. model inheritance:

class GoogleSubscriptionPayment(SubscriptionPayment):
    purchase_token = models.CharField()

class AppleSubscriptionPayment(SubscriptionPayment):
    transaction_id = models.CharField(unique=True)

class PaddleSubscriptionPayment(SubscriptionPayment):
    transaction_id = models.CharField(null=True, blank=True, unique=True)

But refactoring for this would be big.

Seems like HardDbLock on apple payment is the simplest possible solution for current struggles, but l8r it should be refactored to use custom model.

Maybe we should install some "history" app which will track models changes? Would be easier to debug.

from typing import Optional, List
a: Optional[List]

->

from __future__ import annotations
a: list | None