reelyactive / advlib Goto Github PK

Hello!

I'll start off by saying I'm really impressed with the library here.

There does however seem to be some things missing.
When trying to identify a manufacturer with the example from the readme advlib.ble.common.companyidentifiercodes.companyNames['000d']; it throws an error that common is not defined.

When looking at https://github.com/reelyactive/advlib/blob/master/lib/ble/index.js you can see identifiers defined but never exported.

In fact, nothing is exported at all for common.

Is this by design or just an oversight?
I've quickly looked over the source and most of the files seem to be there.

Thanks for this library. Works great except I can't directly process servicedata or other gap packets:

advlib.ble.data.gap.servicedata.process('4941414c72784741414c7359637754714f59493d', 0, {})

Returns Cannot read property 'servicedata' of undefined

Thanks for this library, really helped me out:)

I ran into one problem:
In gatt/services/members/google.js you're checking on 'feaa'.
The uuid I get is 'FEAA' so it won't work because of the case difference.
Maybe you could make it case insensitive?

I now manually change the case and run the process method myself