refactoringguru / design-patterns-typescript Goto Github PK

Hi, I find RefactoringGuru's Problem and Solution scenarios very easy to understand and of high quality.

However, I can't find the sample code for the Problem and Solution sections, so I have to implement the samples like this:

// Decorator Pattern
interface Notifier {
  send(message: string): void;
}

class EmailNotifier implements Notifier {
  constructor(private emails: string[]) {}

  send(message: string): void {
    console.log(`Sending email to ${this.emails}: ${message}`);
  }
}

class SMSDecorator implements Notifier {
  constructor(private notifier: Notifier) {}

  send(message: string): void {
    console.log(`Sending SMS: ${message}`);
    this.notifier.send(message);
  }
}

class FacebookDecorator implements Notifier {
  constructor(private notifier: Notifier) {}

  send(message: string): void {
    console.log(`Sending Facebook message: ${message}`);
    this.notifier.send(message);
  }
}

class SlackDecorator implements Notifier {
  constructor(private notifier: Notifier) {}

  send(message: string): void {
    console.log(`Sending Slack message: ${message}`);
    this.notifier.send(message);
  }
}

const emailNotifier = new EmailNotifier([
  "[email protected]",
  "[email protected]",
]);

const combinedNotifier = new SlackDecorator(
  new FacebookDecorator(new SMSDecorator(emailNotifier))
);

combinedNotifier.send("Important message: House is on fire!");

I am implementing all of the Solution Code like this. Can I contribute to this repository?

I think, all the patterns from this repository should work by "copy and paste", or am i wrong?

For example, in this part of code, typescript will say, that state property does not exists on Subject.

This is not only related to the typescript code samples, it is more related to the book, but I can not find where to submit that kind of issue.

Issue

Once we make attribute: result we should return this.result not this.manual . I know this is only a prototype, but still, I guess this should be applied.

Best,
Vladislav.

Hello, I would like to work on RealWorld examples for this repository (this is my first contribution to a project). Before to start I would really appreciate an ok from the maintainers and, if needed, advices. I will create the PR with examples in the next days :)

In the memento conceptual example, you have the next interface of Memento that will be used by caretakers:

interface Memento  {
    getState(): string;
    getName(): string;
    getDate(): string;
}

Following the pattern - caretakers shouldn't have access to the state that memento stores. But with the above interface, we can call memnto.getState() in any caretaker and receive the state because caretakers operate with memntos with this interface.