refactoringguru / refactoring-examples Goto Github PK

the last has: speed = bird.getSpeed();

but, to create the bird object shouldn't we again create use the swirch case? like this:

switch (type) {
      case EUROPEAN:
        Bird bird=new European();
      case AFRICAN:
       Bird bird=new African()
      case NORWEGIAN_BLUE:
        Bird bird=new NorwegianBlue()
    }

so, what is purpose for this solution actually? or is there something that i missed?

class Gamma have
private importantValue1 and in method compute int importantValue1 and so on...
should it be better delete fields from class and use local variables in method ?
thx!

See this problem: https://refactoring.guru/consolidate-duplicate-conditional-fragments

The problematic code is:

if (isSpecialDeal()) {
  total = price * 0.95;
  send();
}
else {
  total = price * 0.98;
  send();
}

The proposed solution is:

if (isSpecialDeal()) {
  total = price * 0.95;
}
else {
  total = price * 0.98;
}
send();

yet it still duplicates the logic of calculating the total.

A better solution would be something like this:

total = price * (isSpecialDeal() ? 0.95 : 0.98);
send();

Hey there! I stumbled upon your website and have been learning quite a lot about refactoring and design patterns. Thanks for the free content!

I was just wondering if you guys need C++ examples, or examples in any particular language. I see you have C# examples already; I know the two languages are fairly similar except for some OOP semantics, so I was debating the value of adding C++ to the list as a PR.

Thanks!