`use-first-commit-message-for-new-prs` overrides user set title when refreshing page about refined-github

[pgimalac]

I tested what you described and it works properly.
I implemented a fix and it also works as expected. I'll open a PR.

[fregante]

Possible solutions:

• detect session:resume event

I think that's what's refilling the field here

[pgimalac]

@fregante what do you think of just not replacing the title if the page was reloaded, using the logic described in https://stackoverflow.com/questions/5004978/check-if-page-gets-reloaded-or-refreshed-in-javascript/53307588#53307588 ?

Let me know if that would work for you, I can open a PR.

[fregante]

I think we still need to cover reloads for the feature to work normally, right?

If you don't touch the field, what happens when you reload the page? Does first commit stay in the title?

[pgimalac]

I assumed the first time you open the page the feature replaces the title with the first commit, and then when you refresh GIthub restores whatever was in the field, whether it's the first commit or the user wrote something.

I'll give it a try and open a PR if it works properly.

[fregante]

That may be right, it should be tested:

1. Load the page
2. Have Refined GitHub set the title
3. Disable Refined GitHub
4. Reload the page