registerrier / gammapy-ogip-spectra Goto Github PK

This is a test issue to try the diagrams:

flowchart TD
      A[dataset] --> B{Estimator};
      B --yes--> C[FluxEstimate];
      B --> D[Fit];

Doing

datasets = Datasets(datasets=[ogip_dataset])
model = SkyModel(spectral_model=...)

Correctly assigns the model to the ogip_dataset.grouped dataset.

Instead

datasets = Datasets(datasets=[ogip_dataset])
model = SkyModel(spectral_model=..., datasets_names=[ogip_dataset.name])

does not, because the ogip_dataset.name differs from ogip_dataset.grouped.name. This is problematic if one tries to share models between different ogip datasets.

A workaround for this is

datasets = Datasets(datasets=[ogip_dataset])
model = SkyModel(spectral_model=..., datasets_names=[ogip_dataset.grouped.name])

but better solutions will need to be devised.

This is a reminder issue.

We need to fix the StandardOgipDataset.plot_fit() method, which gives odd output like: