release-engineering / exodus-lambda Goto Github PK

Summary

To deploy a lambda function one must copy the function directory, zip the contents of the directory, deploy the .zip to AWS, and clean up the copied directory.

This process should be automated using a small script in either bash or Python.

Issue Type

• Feature Request

Current behavior

The steps described must be manually completed.

Desired behavior

A bash or Python script exists to perform the deployment of a function within cdn-lambda/cdn_lambda/functions/ with as few arguments as possible.

Use case

Automate much of the manual work required to deploy a lambda function.

Additional Information

Deployment steps:

Copy desired function directory to working directory
cp -R src-open/cdn-lambda/cdn_lambda/functions/map_to_s3/ .

Enter the directory and zip the contents
cd map_to_s3 && zip deployment.zip *

Create the function in AWS
aws lambda create-function --function-name map_to_s3 --runtime python3.7 --zip-file fileb://deployment.zip --handler map_to_s3.lambda_handler --role arn:aws:iam::XXXXXXX --region DESIRED-AWS-REGION

Or update an existing function
aws lambda update-function-code --function-name map_to_s3_2 --zip-file fileb://deployment.zip --region DESIRED-AWS-REGION

Clean up deployed function directory
cd .. && rm -rf map_to_s3

Currently there is only one lambda function, in lambda_functions.py.
Based on https://docs.aws.amazon.com/lambda/latest/dg/lambda-python-how-to-create-deployment-package.html, it doesn't seem possible to store multiple lambda functions in a single Python module.
Each lambda function should therefore live in its own, uniquely named module.

Change the name of the existing lambda function and test modules to set the correct precedent for naming.

Dependabot couldn't authenticate with https://pypi.python.org/simple/.

You can provide authentication details in your Dependabot dashboard by clicking into the account menu (in the top right) and selecting 'Config variables'.

View the update logs.

Summary

The uri in the request passed to CloudfFont should begin with a '/'
https://github.com/release-engineering/cdn-lambda/blob/master/cdn_lambda/functions/map_to_s3.py#L44

Issue Type

• Bug Report

Steps to reproduce

Attempt to access a valid path that exists in the ddb + object mappings table.

Actual results

ERROR Validation error: Lambda function result validation failed, the specified URI is in an invalid format, uri must start with '/'.

User receives a "502" error from CloudFront after attempting to access cloudfront-domain.cloudfront.net objectkey):

The Lambda function result failed validation: The specified URI is in an invalid format.

Expected results

The uri in the request that is passed to CloudFront begins with '/'. The user is redirected to object key (i.e., attempts to access cloudfront-domain.cloudfront.net/objectkey))

OS / Environment

Lambda@Edge, Python3.7

Additional Information

Dependabot couldn't authenticate with https://pypi.python.org/simple/.

You can provide authentication details in your Dependabot dashboard by clicking into the account menu (in the top right) and selecting 'Config variables'.

View the update logs.

Summary

Lambda@Edge functions does not support environment variables, yet map_to_s3 depends on DB_TABLE_NAME and DB_TABLE_REGION. Another method of injecting these variables must be implemented.

Issue Type

• Bug Report

Steps to reproduce

Attempt to deploy map_to_s3 function with any environment variables.

Actual results

Function creation is rejected by AWS Lambda

Expected results

Function creation is successful and the function can access determine the correct table to query for mapping.

OS / Environment

Lambda@Edge, Python3.7

Additional Information

Summary

Versioning for the CDN s3 bucket, configured in exodus-storage.yaml, is unnecessarily enabled.

Issue Type

• Bug Report

Steps to reproduce

n/a

Actual results

Versioning is enabled for CDN bucket

Expected results

Versioning is disabled for CDN bucket

OS / Environment

n/a

Additional Information

The documentation for this repository, found in https://github.com/release-engineering/cdn-lambda/tree/master/docs and published at https://release-engineering.github.io/cdn-lambda/, should be improved to list all the available lambda functions and instructions for deploying them.

Dependabot couldn't authenticate with https://pypi.python.org/simple/.

You can provide authentication details in your Dependabot dashboard by clicking into the account menu (in the top right) and selecting 'Config variables'.

View the update logs.

Dependabot couldn't authenticate with https://pypi.python.org/simple/.

You can provide authentication details in your Dependabot dashboard by clicking into the account menu (in the top right) and selecting 'Config variables'.

View the update logs.

Dependabot couldn't authenticate with https://pypi.python.org/simple/.

You can provide authentication details in your Dependabot dashboard by clicking into the account menu (in the top right) and selecting 'Config variables'.

View the update logs.

Other release-engineering/content-delivery projects have issue templates, i.e., https://github.com/release-engineering/pubtools-pulplib/tree/master/.github/ISSUE_TEMPLATE.

Let's add templates like these to this repository.