relick / foundryvtt-right-click-enabler

Allows you to use the standard context menu in places where Foundry does not use right-click.

🎀 Hello! I'm a game developer with interests in Dungeons & Dragons, Touhou Project, C++, and music for the Mega Drive.

🎀 Check my website at kasha.dev

foundryvtt-right-click-enabler's Issues

Doesn't work with foundry vtt 0.8.9

My screen gets blocked and i loose acces the bottom side bar and right side bar

[Compatibility Issue] Replacing 'Game' is not a good idea.

Hello,

It has come to my attention that since 0.8.9 this module breaks libWrapper, as well as some modules that hook a function in Game. A quick investigation shows that this is caused by the fact that you replace the entirety of the Game class with a patched toString() version.

The problem here is that the toString() version of a method/class is not guaranteed to correspond to the actual code, especially if any method has been patched by another module. For example, variables that are from scopes outside the class (e.g. specific to a given method) will not be accessible. Methods might rely on native code and thus contain [native] blocks, etc. Using it for a single method is already an issue sometimes, but using it for an entire class - especially one modified by many modules - is a really bad idea if you want to have good compatibility with other modules.

In this case, libWrapper will patch Game.prototype.initialize to complete its initialisation, but this patch is thrown out when you replace the Game class, causing libWrapper to never fully initialise. This used to work before 0.8.9 as libWrapper would load after your module, but in 0.8.9 the module loading order changed, and now your module loads after.

Some other modules that patch Game also lose their patches and stop working correctly, but neither fails as obviously as libWrapper.

Given you want to remove the line document.addEventListener("contextmenu", ev => ev.preventDefault()); in method Game.prototype.activateListeners, you could achieve the exact same result without being a nightmare for module compatibility, by restricting your patch to the activateListeners method itself, e.g.:

const fnStr = Game.prototype.activateListeners.toString();
const patchedFnStr = fnStr .replace(`document.addEventListener("contextmenu", ev => ev.preventDefault());`, ``);
Game.prototype.activateListeners = Function('"use strict"; return (function ' + patchedFnStr + ')')();

Seems to break FXMaster.

With this module enabled, the menu for FXMaster doesn't render; I only get the first 3 options (nothing after Snow).

Seems odd, but disabling the module gives me back the whole menu.