reloxx13 / sonoff-tasmota-modified Goto Github PK

Used tools:

• Notepad++ v7.5.7

Used Hardware:

• SONOFF-SC

Have you look for this feature in other issues and in the wiki?
-> Yes.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.
-> When you have the SOnOff-SV in use, a envoirement sensor, you will miss
the friendly name on the information web page which can be a little
irritating because when you have set the hostname different you miss it.

Describe the solution you'd like
A clear and concise description of what you want to happen.
-> I have changed a very little part in the xdrv_02_webserver.ino file
to add this information and it works perfect.

Original Code:
if (SONOFF_IFAN02 == Settings.module) { maxfn = 1; }

Changed Code:
if ((SONOFF_IFAN02 == Settings.module) || (SONOFF_SC == Settings.module)) { maxfn = 1; }

Additional context
Add any other context or screenshots about the feature request here.
... i'm willing to help with much more ...

Have you look for this feature in other issues and in the wiki?
-> yes

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.
-> About your comment in sonoff.ino
#define MOD_VERSION_STRING "mod-1.35.3" // Would be great to have a macro that fills this from VERSION ...

Describe the solution you'd like
A clear and concise description of what you want to happen.
-> in the xdrv_02_webserver,ino search for:
--> String func = FPSTR(HTTP_SCRIPT_INFO_BEGIN);
..
..
--> func += F(D_PROGRAM_VERSION "}2"); func += my_version;

Then add a new line:
--> func += F("}1" D_PROGRAM_VERSION "}2"); func += MOD_VERSION_STRING;

It can be done also as if:
#ifdef MOD_VERSION_STRING
func += F("}1" D_PROGRAM_VERSION "}2"); func += MOD_VERSION_STRING;
#endif

D_PROGRAM_VERSION_MOD has to be added to all the language files.
This fix is for the web page only.

When it is needed in status 0 in json format then we have to add some parts in the json creation.
For that i must search a little bit more in all the snprintf calls for json. That's then the define for
#define D_JSON_VERSION "Version" in the file i18n.h

Here a screenshot and yes i forgot the next line command and it's the idea behind it:

And here the corrected one and the name can be like 'Modded Version' or something else:

Hi kannst du dieses bitte in deinen Mod aufnehmen?
Wäre dir sehr dankbar!

arendst#2789 (comment)

Hi @reloxx13

The issues tab in your Tasmota_Modified is off.

I just want to give you other ideas for your modified Tasmota version that arendst did not add to the main version:

1) Automatic set of MQTT_MAX_PACKET_SIZE (on compiling time) so there is no need of modifying another library.
EDIT: Dont work

From line 42 in original Sonoff.ino v5.12.0b:

// Max message size calculated by PubSubClient is (MQTT_MAX_PACKET_SIZE < 5 + 2 + strlen(topic) + plength)
#if (MQTT_MAX_PACKET_SIZE -TOPSZ -7) < MIN_MESSZ  // If the max message size is too small, throw an error at compile time. See PubSubClient.cpp line 359
  #error "MQTT_MAX_PACKET_SIZE is too small in libraries/PubSubClient/src/PubSubClient.h, increase it to at least 1000"
#endif

change that with:

// Max message size calculated by PubSubClient is (MQTT_MAX_PACKET_SIZE < 5 + 2 + strlen(topic) + plength)
#if (MQTT_MAX_PACKET_SIZE -TOPSZ -7) < MIN_MESSZ  // If the max message size is too small, throw a warning at compile time. See PubSubClient.cpp line 359
  #warning "MQTT_MAX_PACKET_SIZE is too small in libraries/PubSubClient/src/PubSubClient.h, increasing it to 1000"
  #undef MQTT_MAX_PACKET_SIZE
  #define MQTT_MAX_PACKET_SIZE 1000
#endif

2) Automatic order of words for Device Title (on compiling time) depending on the language chosen.

From line 101 in original webserver.ino v5.12.0b:

#ifdef LANGUAGE_MODULE_NAME
  "<div style='text-align:center;'><h3>" D_MODULE " {ha</h3><h2>{h}</h2></div>";
#else
  "<div style='text-align:center;'><h3>{ha " D_MODULE "</h3><h2>{h}</h2></div>";
#endif

change that with:

#if MY_LANGUAGE == es-AR || MY_LANGUAGE == fr-FR || MY_LANGUAGE == it-IT
  "<div style='text-align:center;'><h3>" D_MODULE " {ha</h3><h2>{h}</h2></div>";
#else
  "<div style='text-align:center;'><h3>{ha " D_MODULE "</h3><h2>{h}</h2></div>";
#endif

3) Solve Security issue: MQTT Server Password is being sent to the config web page and can be seen using chrome ShowPassword Extension.

From line 874 in original webserver.ino v5.12.0b:

page.replace(F("{m5"), (Settings.mqtt_pwd[0] == '\0')?"0":Settings.mqtt_pwd);

change that with:

page.replace(F("{m5"), "**********");

AND

From line 1062 in original webserver.ino v5.12.0b:

strlcpy(Settings.mqtt_pwd, (!strlen(tmp)) ? MQTT_PASS : (!strcmp(tmp,"0")) ? "" : tmp, sizeof(Settings.mqtt_pwd));

change that with:

strlcpy(Settings.mqtt_pwd, (!strlen(tmp)) ? "" : (strchr(tmp,'*')) ? Settings.mqtt_pwd : tmp, sizeof(Settings.mqtt_pwd));

4) Add available options for Log Level on comments.

From line 63 in original user_config.h v5.12.0b add comments:

#define SYS_LOG_LEVEL          LOG_LEVEL_NONE    // [SysLog]  LOG_LEVEL_NONE, LOG_LEVEL_ERROR, LOG_LEVEL_INFO, LOG_LEVEL_DEBUG, LOG_LEVEL_DEBUG_MORE
#define SERIAL_LOG_LEVEL       LOG_LEVEL_NONE    // [SerialLog]  LOG_LEVEL_NONE, LOG_LEVEL_ERROR, LOG_LEVEL_INFO, LOG_LEVEL_DEBUG, LOG_LEVEL_DEBUG_MORE
#define WEB_LOG_LEVEL          LOG_LEVEL_INFO    // [WebLog]  LOG_LEVEL_NONE, LOG_LEVEL_ERROR, LOG_LEVEL_INFO, LOG_LEVEL_DEBUG, LOG_LEVEL_DEBUG_MORE

Other ideas I'm working on:

1-If STA_SSID1 and STA_SSID2 are empty, and there is no SSID configuration saved on EEPROM (or coming from a config reset) the WIFI_CONFIG_TOOL change to be WIFI_MANAGER.
So, after a successful wifi setup, WIFI_CONFIG_TOOL change to the one set on user_config.h

The idea behind this is: When you flash a new Sonoff, it will ask for wifi credentials. After it connects, it can change automatically to WIFI_RETRY or WIFI_WAIT for reconnecting when losing connection.

I know that WIFI_MANAGER can be set on user_config.h, and then, with SonWEB, change it to WIFI_RETRY. But the idea is to be automatic.

Beside, if then you change your wifi credentials, you can push 4 times the button1 (at any time) and activate the WIFI_MANAGER

2-Trying to solve the Bug that when the MQTT server is down, Tasmota dont respond to button pressings.
PubSubClient Library is the one with the Lag. The author said that when MQTT is down the lag is on the wificlient library. So, the people from the esp library recommend use martin-ger/esp_mqtt that don't make that lag because it uses callbacks.
So, i'm testing if changing the library can be a solution.
EDIT: NOW SOLVED Tasmota Issue #1992

3-Adding KNX protocol support.
EDIT: NOW WORKING on Sonoff-Tasmota_KNX, when it reaches a working level I can add the driver to this one if you like.

by @ascillato

This BUG issue template is meant to REPORT Tasmota software BUGS ONLY>

BUG DESCRIPTION

A clear and concise description of what the bug is.

REQUESTED INFORMATION

Make sure these boxes are checked before submitting your issue. Thank you

FAILURE TO COMPLETE THE REQUESTED INFORMATION WILL RESULT IN YOUR ISSUE BEING CLOSED

• Read the Contributing Guide and Policy and the Code of Conduct
• Searched the problem in issues (https://github.com/arendst/Sonoff-Tasmota/issues)
• Searched the problem in the wiki (https://github.com/arendst/Sonoff-Tasmota/wiki/Troubleshooting)
• Searched the problem in the forum (https://groups.google.com/d/forum/sonoffusers)
• Searched the problem in the chat (https://discord.gg/Ks2Kzd4)
• Device used (i.e. Sonoff Basic) : _____
• Tasmota binary firmware version number used : ____ / (pre-compiled or self-compiled ?)
• Development IDE - Compiler / Upload tools used : ____ / ____
• Provide the output of command status 0 :

STATUS 0 OUTPUT HERE:

• Provide the output of console when you experience your issue if apply :
  (Please use weblog 4 for more debug information)

CONSOLE OUTPUT HERE:

TO REPRODUCE

Steps to reproduce the behavior:

EXPECTED BEHAVIOUR

A clear and concise description of what you expected to happen.

SCREENSHOTS

If applicable, add screenshots to help explain your problem.

ADDITIONAL CONTEXT

Add any other context about the problem here.

(Please, remember to close the issue when the problem has been addressed)

PROBLEM DESCRIPTION

platformio_tasmota_env.ini contains wrong value for tasmota-lite actually is:

[env:tasmota-lite]
build_flags = ${common.build_flags} -DFIRMWARE_LITE

it should be:

[env:tasmota-lite]
build_flags = ${env.build_flags} -DFIRMWARE_LITE

otherwise compiled version has wrong values in free memory and no further update will work except hardware flash

REQUESTED INFORMATION

Make sure your have performed every step and checked the applicable boxes before submitting your issue. Thank you!

• Read the Contributing Guide and Policy and the Code of Conduct
• Searched the problem in issues
• Searched the problem in the docs
• Searched the problem in the forum
• Searched the problem in the chat
• Device used (e.g., Sonoff Basic): _____
• Tasmota binary firmware version number used: _____
  • Pre-compiled
  • Self-compiled
    • IDE / Compiler used: _____
• Flashing tools used: _____
• Provide the output of command: Backlog Template; Module; GPIO 255:

  Configuration output here:

• If using rules, provide the output of this command: Backlog Rule1; Rule2; Rule3:

  Rules output here:

• Provide the output of this command: Status 0:

  STATUS 0 output here:

• Provide the output of the Console log output when you experience your issue; if applicable:
  (Please use weblog 4 for more debug information)

  Console output here:

TO REPRODUCE

Steps to reproduce the behavior:

EXPECTED BEHAVIOUR

A clear and concise description of what you expected to happen.

SCREENSHOTS

If applicable, add screenshots to help explain your problem.

ADDITIONAL CONTEXT

Add any other context about the problem here.

(Please, remember to close the issue when the problem has been addressed)

How do I make a command on the thermostat or humidifier console using a DHT11?

A clear and concise description of what the bug is.

When you take a look at the table for the sensor values and text
for a SOnOff-SC envoirment module you can see a space before the
text for Temperature and Humidity. The rest of the text is ok without
a space character before the text.

Also, make sure these boxes are checked [x] before submitting your issue - Thank you!

• [x ] Searched the problem in issues and in the wiki
  --> Yes and nothing found ;-)

• [x ] Hardware used :
  --> SONOFF-SC with an external AM2302 T&H sensor
  Fugure 1:
  

• [x ] Provide the output of command status 0 :
  --> NOT needed in this case

To Reproduce
Steps to reproduce the behavior:
->Open the web page for the sonoff-sc module
->Wait 3 or 4 seconds to get the first values
->Cut the network connection
->Goto Inspect the web page (CTRL+SHIFT+I)
->Open the table defines near

2MB-DE-firmware-6.5.0.9-mod-1.45.10.bin is only 1MB