remedyit / ciaox11 Goto Github PK

Within DDSX11 there are several administrations to match native DDS entities with their related DDSX11 proxy. This administration is done based on DDS::InstanceHandle_t but we found that this is not guaranteed to be process wide unique. It could happen that there are multiple DDS entities having the same DDS::InstanceHandle_t within the same process. We raised an issue at the OMG to get this clarified in the specification.

Because we are using the IDL to C++ language mapping from the native DDS vendor we can use the pointer to the native DDS entities, that pointer is unique within the same process.

With OpenDDS the DDS::InstanceHandle_t is unique within the domain participant, it is a int32_t counter that starts with 1 and is incremented when a new InstanceHandle_t is needed. In my test each domain participant gets the InstanceHandle_t 6, the handles 1-5 are used for the builtin entities related to that DomainParticipant

The DDS v1.5 specification will add support for DDS::STATUS_MASK_NONE and STATUS_MASK_ALL, see https://issues.omg.org/browse/DDS15-10. Would require an extension to IDL, logging formatter change (with new test), and update all examples/tests including DDS4CCM to use this new mask

Product
AXCIOMA

Version
AXCIOMA 2.1

Describe the bug
Using

To Reproduce
Compile in examples/shapes_asm/ports the shapes_shapetype_msg.idl without an export include, for example

../../../../../../bin/ridlc -Wb,pre_include=ace/pre.h -Wb,post_include=ace/post.h -I/home/johnny/ACE/axcioma/taox11  -Sci -Ssi -Sa -St -Gddsx11,adds  -I../../../../../ddsx11/vendors/ndds/idl -I../../../../.. -SS -Ssh -Scc -Sch -Scp -Scdr  -I. -Ibuild -Igenerated_code -Gos -o generated_code shapes_shapetype_msg.idl -v -v -v

Expected behavior
No error, a missing typesupport export could lead to unresolved symbols when other shared libraries would use a symbold that is not exported

Output

RIDL - processing input
undefined method `to_random_include_guard' for nil:NilClass
/home/johnny/ACE/axcioma/taox11/ridlbe/c++11/writers/exportheader.rb:30:in `initialize'
/home/johnny/ACE/axcioma/ciaox11/ridlbe/ccmx11/facets/dds/config.rb:197:in `new'
/home/johnny/ACE/axcioma/ciaox11/ridlbe/ccmx11/facets/dds/config.rb:197:in `gen_typesupport_export'
/home/johnny/ACE/axcioma/ciaox11/ridlbe/ccmx11/facets/dds/config.rb:217:in `gen_impl_for_type_support'
/home/johnny/ACE/axcioma/ciaox11/ridlbe/ccmx11/facets/dds/config.rb:104:in `block (2 levels) in <module:DDSX11>'
/home/johnny/ACE/axcioma/taox11/ridlbe/base/config/facet.rb:170:in `process_input'
/home/johnny/ACE/axcioma/taox11/ridlbe/base/config/facet.rb:385:in `block in process_input_with_facets'
/home/johnny/ACE/axcioma/taox11/ridlbe/base/config/facet.rb:385:in `each'
/home/johnny/ACE/axcioma/taox11/ridlbe/base/config/facet.rb:385:in `process_input_with_facets'
/home/johnny/ACE/axcioma/ridl/lib/ridl/runner.rb:204:in `block in run'
/home/johnny/ACE/axcioma/ridl/lib/ridl/genfile.rb:56:in `transaction'
/home/johnny/ACE/axcioma/ridl/lib/ridl/runner.rb:201:in `run'
/home/johnny/ACE/axcioma/ridl/lib/ridl/runner.rb:501:in `run'
../../../../../../bin/ridlc:31:in `<main>'

OpenDDS 3.19 will have a change that ServiceParticipant::shutdown() has a return code which we should check in DDSX11, see OpenDDS/OpenDDS#3159