remind101 / request_id Goto Github PK

the Rack examples (and possibly all the examples) don't seem to be the correct format anymore

There were breaking changes as of sidekiq 5.0 that affect request_id. Namely, some class renaming around logging:

Sidekiq::Middleware::Server::Logging -> Sidekiq::JobLogger

That removed class appears to be used in

Errors look something like:

superclass must be a Class (Module given)

Has anyone had luck attempting an update? I will do some tests and report back.

In #7 functionality was added to generate a request id if it doesn't exist already (based on a configuration value). However, in #13 it appears that this functionality was unintentionally removed. Or at least, if is was intentional, it wasn't mentioned in the PR comments, and the configuration values are still in master.

I would like to use this functionality. If I filed a PR to restore it, would you merge, or is there another reason it was removed?

Add some sidekiq server middleware that pulls the request_id from the job message and set Thread.current[:request_id] so that the request_id can be passed through nested jobs.

Hi request_id folks,

We're interested in using this library but it appears there has been no work on master since 9/2015.

Is this library actively maintained? Would y'all accept new maintainers if we found folks willing to adopt it?

Thanks for this gem!