renoki-co / hej Goto Github PK

Hello! 👋🏻

Maybe it's a misconfiguration on my part, but Hej doesn't redirect to provider 😕

I've been checking RenokiCo\Hej\Http\Controllers\SocialController, and apparently @redirect and @callback are not present, however I did find them in Concerns\HandlesSocialRequests.php 🤔

Could it be a mistake?

Background

In my application, I'm using enforceMorphmap

// AppServiceProvider.php
public function boot()
{
    Relation::enforceMorphMap([
        'User' => \App\Models\User::class,
    ]);
}

because of that, the data on socials table will be like this

notice on model_type is stored as User not App\Models\User.

Issue

Expected
When I want to login via oauth and socials table already filled with same email with login.
User should be automatically login.

Actual
SQL error unique email (since I setup my database email column as unique index). It means the application is trying to create new user instead of automatically login

Investigation

1. Error happens on callback handler in controller.
2. Logic flow should happen inside this https://github.com/renoki-co/hej/blob/master/src/Concerns/HandlesSocialRequests.php#L116
3. It seems $model is null caused by getModelBySocialId return null
4. getModelBySocialId is `null caused by https://github.com/renoki-co/hej/blob/master/src/Concerns/HandlesSocialRequests.php#L211
5. 'getSocialId` is null caused by https://github.com/renoki-co/hej/blob/master/src/Concerns/HandlesSocialRequests.php#L230

Solution

Maybe this can help https://laravel.com/docs/9.x/eloquent-relationships#custom-polymorphic-types

Currently, the redirect logic is handled in the SocialController and always returns Redirect::route('home'). This causes some problems for apps who don't have a route named home. Ofc you can always override the SocialController class and write your own redirect response, but I think it would be a better user experience (for the developer) if the redirection logic is a bit more flexible by default.

If we take the login request then we could take the same approach that laravel/ui has taken for the redirect. That d mean that instead of calling authenticated() before authenticateModel(), we would call it afterwards.

// login logic
$social = $this->updateSocialInstance($request, $provider, $model, $providerUser);

$this->authenticateModel($model);

if ($response = $this->authenticated($request, $model, $social, $providerUser)) {
     return $response;
}

return redirect()->intended($this->redirectPath());

// redirectPath
    protected function redirectPath()
    {
        if (method_exists($this, 'redirectTo')) {
            return $this->redirectTo();
        }

        return property_exists($this, 'redirectTo') ? $this->redirectTo : route('home');
    }

That way we could utilize the alreadyt existent registered, authenticated, linked and unlinked methods to do custom redirects if required.

Would you be open to a PR which would make the necessary changes to the codebase @rennokki ?