Hide lines when inactive about tesla-style-solar-power-card

[reptilex]

I did a quick implementation of it, currently it's not the default, althhough I'm thinking it maybe shoud. Add "hide_inactive_lines" in the card config and set it to 1. Then you will have only active lines.

[fvgarrel]

Cool, thanks for the quick implementation and response, I love it :)

[DRAGandDROP]

when enabling the feature the "points" do not move anylonger. only the line is visible. Is it a feature or a bug? ;)

just found it. it's because i'm using
show_w_not_kw: 1
this causes the points to stop moving.

[PierreScerri]

Dots were moving with 9.1.2 and show_w_not_kw:1
Dots stopped moving with 9.2.1 and show_w_not_kw:1

[msim888]

There is an error in 9.2.1

The speed variable is wrong

The last a few rows have to be:

  getSpeed(value) {
    var speed = 0;
    
    if (value > 0 && this.w_or_kw !== 'W') {
      speed = 0.07 * value;
    } else if (value > 0 && this.w_or_kw === 'W') {
      speed = 0.00007 * value;
    }
    
    return speed;
  }
}

customElements.define('tesla-style-solar-power-card', TeslaStyleSolarPowerCard);

Then everything works very well:

[msim888]

But I have another issue:

There is solar circle even it the solar power is 0

[fvgarrel]

But I have another issue:

There is solar circle even it the solar power is 0

Because your battery is charging.

[msim888]

Yeah, but it is charging only from grid, not from sun - it's night here.

[fvgarrel]

Yeah, but it is charging only from grid, not from sun - it's night here.

Yes. The Solar to Battery Path is activated when the battery is loading. Maybe the Code should look from where the energy is coming.

[msim888]

Oh, I see, Thanks, fvgarrel!

[LanceMcCarthy]

Hiding the lines when not active is the behavior of the Tesla app. However, I do not think this should be the default for the card. Let me explain...

If the default for the card was to hide them, the the user wouldn't know if a missing line was due to an incorrect configuration or it is working as expected

Therefore, my vote is to show lines by default.

That said, you can add a note at the end of the Getting Started steps to set the "HideLines property once everything is confirmed working".

if you do make hiding the lines the default behavior, please show an error state (i.e. dotted red line for an incorrectly configured setting)

[msim888]

Totally agree with LanceMcCarthy.
My vote is to show lines by default too.

[reptilex]

I somehow overwrote the speed changes for the w_not_kw behaviour, very sorry and thanks for raising the issue. It should be online, but I have not yet created a new release. Will do so as soon as I have figured out the issue with the charging line duplication when charging from grid. I have created another issue for that @msim888 can you follow that one, I have some questions there.
On the bright side, all but those lines work so I will see this as a feature finish state and close the issue.