GithubHelp home page GithubHelp logo

Comments (3)

ib-lundgren avatar ib-lundgren commented on July 24, 2024

I agree. A way both could be achieved would be to combine the state and state_generator arguments to one, state and document that it can be a callable or string, then check for TypeError. The overloaded use of self.state would need to change so to internally track the actually used state instead use self._state.

def new_state():
    try:
        self._state = self.state()
    except TypeError:
        self._state = state

@FelixSchwarz fancy making those changes and sending a PR? Don't worry if you don't have time, I can find some soonish.

from requests-oauthlib.

FelixSchwarz avatar FelixSchwarz commented on July 24, 2024

Am 18.06.2013 16:57, schrieb Ib Lundgren:

@FelixSchwarz https://github.com/FelixSchwarz fancy making those changes and
sending a PR? Don't worry if you don't have time, I can find some soonish.

Well currently I have approximately zero free time so I'd be glad if you could
fix it :-) Thank you very much for picking up the issue so quickly.

from requests-oauthlib.

ib-lundgren avatar ib-lundgren commented on July 24, 2024

state is no longer ignored and can be either a string or a callable. It should no longer be ignored in new_state =)

from requests-oauthlib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.