GithubHelp home page GithubHelp logo

Comments (6)

sigmavirus24 avatar sigmavirus24 commented on July 4, 2024

+1

from requests-oauthlib.

Lukasa avatar Lukasa commented on July 4, 2024

This is a good idea! However, it will not be fixed in the next version of requests-oauthlib because I want 0.3.4 to make people's lives as easy as possible. =)

from requests-oauthlib.

ib-lundgren avatar ib-lundgren commented on July 4, 2024

Think the only place this would break would be the redirect_uri param and if we want to be careful we could always add redirect_url as a param and raise a deprecation warning when people pass in redirect_uri.

from requests-oauthlib.

Lukasa avatar Lukasa commented on July 4, 2024

@ib-lundgren Not a bad idea: we should also raise a new issue to remind us to get rid of it eventually. =)

from requests-oauthlib.

KVGarg avatar KVGarg commented on July 4, 2024

@Lukasa @ib-lundgren As a newcomer, I would like to work upon this issue. Can I ?

from requests-oauthlib.

tomdottom avatar tomdottom commented on July 4, 2024

a) I agree that a uniform use of one of uri & url is desirable; but
b) I would advocate uri over url

Why b)?

  • redirect_uri is commonly used. AWS, Google, Auth0 will report redirect_uri mismatch errors
    • it may be confusing to set redirect_url and get a redirect_uri error.
    • if we assume we should use redirect_uri here all others should follow uri convention
  • the underlying oauthlib uses the term uri
  • a url is a uri, but a uri is not a url

from requests-oauthlib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.