GithubHelp home page GithubHelp logo

Comments (6)

nicksloan avatar nicksloan commented on June 26, 2024

I'd be happy to get into this a bit, if no one is working on it. Need this for something I'm working on at the moment.

from requests-oauthlib.

thedrow avatar thedrow commented on June 26, 2024

It seems that my server wasn't returning token_type as part of the response. So this issue should turn into "Add a clearer missing token type error message".

from requests-oauthlib.

nicksloan avatar nicksloan commented on June 26, 2024

@thedrow Thanks for the update. Looking at this, I'm not sure that any work really needs to be done here. It seems to me that raising MissingTokenTypeError is pretty clear about what went wrong. What's more, that is actually the behavior of oauthlib, so it's not particularly suitable for requests-oauthlib to address the issue.

I propose we close this issue.

from requests-oauthlib.

thedrow avatar thedrow commented on June 26, 2024

I had to print the response to figure this out. It wasn't easy and it took me about an hour and a half to debug this.
The only thing that should be done is to provide a better error message.

from requests-oauthlib.

nicksloan avatar nicksloan commented on June 26, 2024

Even so, that is an issue for oauthlib, not requests-oauthlib. Look at where the exception is being raised. It's not in requests-oauthlib code. If simply raising MissingTokenTypeError is not enough, I think that is an issue for oauthlib to address, rather than adding code to raise a new exception to say essentially the same thing in requests-oauthlib.

from requests-oauthlib.

ib-lundgren avatar ib-lundgren commented on June 26, 2024

@thedrow @nicksloan better error messages are always nice whichever repo, will open a little todo on oauthlib to look into this.

from requests-oauthlib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.