The resilience4clj-retry's discuss from resilience4clj

resilience4clj-retry's Issues

Fix `retry/create` example

Thanks for the sweet lib!

The example of how to create a retry with configuration doesn't run:

(def retry (r/create {:max-attempts 10
                      :wait-duration 300}))
clojure.lang.PersistentArrayMap is in unnamed module of loader 'app'; java.lang.String is in module java.base of loader 'bootstrap')

This example requires a name string, e.g.

(def retry "my-retry" (r/create {:max-attempts 10
                      :wait-duration 300}))
=>
#object[io.github.resilience4j.retry.internal.RetryImpl
        0x4941ec8f
        "io.github.resilience4j.retry.internal.RetryImpl@4941ec8f"]

Fixing this would help others get started with the library, as I ran into this issue myself trying to get set up.

Not retrying when Exception is thrown

I have existing functions that I'm attempting to decorate as retriable, but I'm noticing that retry is not triggered when java.lang.Exception is thrown, I'm not sure if this is an issue with the upstream dependency, but I can repro it with this code:

(require '[resilience4clj-retry.core :as r])
(def retry (r/create "test-retry"))
(r/listen-event retry
                :RETRY
                (fn [_] (println "retrying...")))

;; 1. Exception
(def retriable-fn
  (r/decorate
    (fn [] (throw (Exception. "not good")))
    retry))

(retriable-fn)
;; Execution error at retry/fn (retry.clj:4).
;; not good

;; 2. ex-info
(def retriable-fn
  (r/decorate
    (fn [] (throw (ex-info "not good" {})))
    retry))

(retriable-fn)
;; retrying...
;; retrying...
;; Execution error (ExceptionInfo) at retry/fn (retry.clj:3).
;; not good

;; 3. Exception caught and re-thrown as ex-info
(def retriable-fn
  (r/decorate
    (fn [] (throw (ex-info "not good" {} (Exception. "not good"))))
    retry))

(retriable-fn)
;; retrying...
;; retrying...
;; Execution error at retry/fn (retry.clj:3).
;; not good