resonance-cascade / cache-component Goto Github PK

Since we use an ID system to match nodes now, maybe we can go back to not morphing internally. Or maybe we do, since its more contained that way.

...but only after we land choojs/nanocomponent#38 in beta at least.

• Add better examples,
• Slim down the docs
• Document some of the tricks you can do with this
• Have an ES6 class example

Testing dom nodes in node doesn't work well.

At the moment, due to this line, any element with mutating children is never cached. Actually what happens is the original element is cached, but the proxy never gets replaced with the cached element, so after one change the cached element drops permanently from the DOM.

This is because mutating a child element changes the identity of the element, so el === self._element will be false.

This is being discussed over at nanomorph too.

I propose that the simplest solution is to check whether the element has an id attribute during proxy creation. If it does, copy the id to the proxy, then use id comparison instead of element equality:

CacheElement.prototype._createProxy = function () {
  var el = this._hasWindow ? document.createElement('div') : this._element
  el.setAttribute('data-cache-component', '')
  if (this._element && this._element.id) {
    el.setAttribute('id', this._element.id)
  }
  var self = this
  el.isSameNode = function (el) {
    return self._element.id ? el.id === self._element.id : el === self._element
  }
  return el
}

PR incoming...

They are all set to cahce-element still.

How the hell did I update the name CacheElement?

If you have two instances of the same component, and try to morph one into the other, you lose the correct internal reference to the real DOM node inside of the component instance on _element. The work around here is to correctly ID using a unique instance ID.

Instance clobbering bug:

https://gist.github.com/bcomnes/fa4fa3a83807b4189356699c17207a0b

shama/on-load#22

I think I solved it in an incoming PR.