revalto / ao-network

Albion Online Network NodeJS

Привет, Я ✨Revalto✨ 👋

Обо мне

• 🌱 В данный момент я обучаюсь
• 👯 Я хочу сотрудничать с другими разработчиками
• 🥅 Цель на 2020: повысить свой опыт
• ⚡ Интересный факт: сам не знаю 🤣

---

👥 Связь

---

⚡ 👥 Языки и инструменты

---

ao-network's Issues

Potential Deserialization Issue (Long) & Operations List Fix

Hi. First of all, thanks for creating this. I was able to successfully intercept packets and decode them with your solution.

There is 1 issue I found that I fixed. There is another one that I am not sure where it lies, but I suspect it's within deserialization.

First of all, the operations list needs to be fixed, as the codes are wrong. See following file for correct list: https://jsfiddle.net/tcLeqk8x/

However, I think there is an issue with deserialization. I looked at the parameters of some known packets. As an example: "HealthUpdate". I have annotated the known parameters. I suspect it's somewhere within the deserialization of the Long type. I don't know too much about working with buffers so it's hard for me to fix.

{
'0': 1048576, //ObjectID --> Looks wrong. Should not be the same as '6'. It's (Int64Type / Long)
'1': 67108864, //Gametimestamp (I am pretty sure there is an issue here, because this does not change as time passes currently).
'2': -37, //Damage Done, Health Received --> Looks Good
'3': 1599 //New Health Value --> Looks good
'4': 1, //Effect Type ---> Not sure if correct
'5': 0, //Effect Origin --> Not sure if correct
'6': 1048576, //ID of player causing damage. This should not be the same as parameter '0', so probably an issue here.
'7': 65535, //Spellytype
'252': 6,
type: 'HealthUpdate' // I added this property myself so I know which packet is which
}

it seems AODecoder.js missing some codes maybe?

Hi.

I'm newbie developer and I don't understand most of codes,
but I think I found some missing points.

inside of libs/AODecoder.js, there is a method handleSendFragment.
it seems there should be one more commandLength -= 4; inside of it.

handleSendFragment(p, commandLength) {
        const startSequenceNumber = p.ReadUInt32();
        commandLength -= 4;
        const fragmentCount = p.ReadUInt32();
        commandLength -= 4;
        const fragmentNumber = p.ReadUInt32();
        commandLength -= 4;
        const totalLength = p.ReadUInt32();
        commandLength -= 4;
        const fragmentOffset = p.ReadUInt32();
        // commandLength -= 4;  // <--- Missing Point

        let fragmentLength = commandLength;

        this.handleSegmentedPayload(startSequenceNumber, totalLength, fragmentLength, fragmentOffset, p);
}

Without that code, sometimes it break some data like didn't deserialized yet. There is "\x00\x00\x00\x00" inside always.
{"Id":9693839799,"UnitPriceSilver"\x00\x00\x00\x0030000,"TotalPriceSilver":1443330000,"Amount":21,"Tier":7

I'm not sure that I'm right, but after I added commandLength -= 4;, it works like magic :)
I hope you can check this out, and thank you for the codes with javascript! It helps me a lot 👍 👍