revdotcom / revai-go Goto Github PK

As a RevAi golang sdk user, I would like to be able to specify the option to attach custom vocabulary when using the async api client.

This issue is being opened in an effort to reach feature parity with the streaming websocket API.

The async API feature is documented here: https://www.rev.ai/docs#operation/SubmitTranscriptionJob

Hi I'm missing this commit on latest release 147b336

As a RevAi golang sdk user, I would like to be able to specify the option to remove disfluencies from my transcript when using the streaming client.

This issue is being opened in an effort to reach feature parity with the streaming websocket API.

The feature is documented here: https://www.rev.ai/docs/streaming#section/WebSocket-Endpoint/Remove-Disfluencies-(Beta)

Looks like GoDoc is referring to 0.0.3 to an old namespace (oriiolabs) and is not picking up the LICENSE preventing the godoc from being published. Also when doing go get .... it will pick up 0.0.3 rather than latest. If the link between godoc and this repo could be fixed that would be great thanks!

https://github.com/threeaccents/revai-go/blob/cf7acb41981be028560645c82f9c2285060fc198/stream.go#L222

seems to be missing some errors. As a consequence we are getting a panic.

This panic indicates read is being called even though the socket has closed/failed.
https://github.com/gorilla/websocket/blob/c3dd95aea9779669bb3daafbd84ee0530c8ce1c1/conn.go#L1001

As a RevAi golang sdk user, I would like to be able to specify the option to attach custom vocabulary when using the streaming client.

This issue is being opened in an effort to reach feature parity with the streaming websocket API.

The websocket streaming API feature is documented here: https://www.rev.ai/docs/streaming#section/WebSocket-Endpoint/Custom-Vocabulary

https://github.com/threeaccents/revai-go/blob/master/LICENSE#L10 has doJSON instead of do

Add new job option custom_vocabulary_id to the async api job options as defined by the REST API documentation: https://www.rev.ai/docs#operation/SubmitTranscriptionJob

calling close at https://github.com/oriiolabs/revai-go/blob/12ab04b8107ea2b74719780fc36d8a9ac3ed4121/stream.go#L61
causes a double close due to https://github.com/oriiolabs/revai-go/blob/12ab04b8107ea2b74719780fc36d8a9ac3ed4121/stream.go#L110

I've seen this line on this example and I think is pointing to old module path.
https://github.com/revdotcom/revai-go/blob/master/examples/streaming/stream.go#L12

As a RevAi golang sdk user, I would like to be able to delete my custom vocabulary when using the async api client.

This issue is being opened in an effort to reach feature parity with the Custom Vocabulary API.

The REST API feature is documented here: https://www.rev.ai/docs/streaming#operation/DeleteCustomVocabulary

As a rev.ai golang sdk user, I would like to be able to submit transcription for languages other than English. Add support for the new language parameter as documented on page: https://www.rev.ai/docs#operation/SubmitTranscriptionJob

New Languages supported at this time are English, Spanish, Portuguese, French and German. Language parameter is provided as a ISO 639-1 2-letter language code.

This issue is being filed in an effort to bring the golang sdk into feature parity with the async transcription api.