GithubHelp home page GithubHelp logo

Comments (3)

dave08 avatar dave08 commented on May 27, 2024

Why? I think injectNow is pretty clear? And get() could be pretty common in class code (like the operator overload and in collections)... although usually collections don't get injected. This is also a breaking change that could involve quite a bit of refactoring for some...

from katana.

svenjacobs avatar svenjacobs commented on May 27, 2024

I'm not really satisfied with the adverb now in injectNow(). Do users know now from other frameworks? I don't think so.

I don't see a conflict when using get() like

private val someDependency: SomeDependency = component.get()

Can you please show examples of where you think this could be problematic?

from katana.

dave08 avatar dave08 commented on May 27, 2024

Well, when you have a class implementing KatanaTrait (it might seem a bit contrived, but I've encountered things I didn't think I would do when I migrated...):

class SomeClass : KatanaTrait {
	private val someDependency: SomeDependency = get()

	...

	operator fun get() = ...
}

Also, the main problem I have is that it might be a bit funny understanding what you're getting... in the context of a class with other things that are being gotten inject is clear whereas get() is a bit general and could be interpreted as something else...

from katana.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.