GithubHelp home page GithubHelp logo

Rename singleton about katana HOT 5 CLOSED

rewe-digital avatar rewe-digital commented on May 23, 2024
Rename singleton

from katana.

Comments (5)

aartikov avatar aartikov commented on May 23, 2024 1

scoped

from katana.

dave08 avatar dave08 commented on May 23, 2024

Maybe rename Module instead in a way that it's clear that it doesn't contain instances?

from katana.

dave08 avatar dave08 commented on May 23, 2024

Maybe ModuleDeclaration or something?

from katana.

svenjacobs avatar svenjacobs commented on May 23, 2024

I'm not really sure if renaming Module is a solution. I actually like the name and the concept of modules and components should be clear from other DI frameworks like Dagger.

I prefer scoped. What if we keep singleton as an alias to scoped?

from katana.

dave08 avatar dave08 commented on May 23, 2024

Dagger also declares Singletons in their modules and only saves them in components (although there aren't multiple components like in Katana... so @Singleton or @ActivityScope, etc... is the real indicator of what happens), so that's also a concept that's clear for those coming from there... In a sense, in Dagger a Singleton is just another type of scoped value though, and users can make their own, so the distinction between singleton and scoped is required there. In Katana, the scope is really managed by multiple components.

That said, if singleton is left around, it doesn't really matter to me if there's also scoped 😄, I'm personally more used to singleton...

from katana.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.