GithubHelp home page GithubHelp logo

libidn2 breaks CIDR notation about whois HOT 7 CLOSED

rfc1036 avatar rfc1036 commented on July 21, 2024
libidn2 breaks CIDR notation

from whois.

Comments (7)

rfc1036 avatar rfc1036 commented on July 21, 2024

Looks like idn2_lookup_ul() really normalizes non-domains, so I will need to restructure the code to support libidn2, but this will take some time.
Cc @rockdaboot

from whois.

rockdaboot avatar rockdaboot commented on July 21, 2024

Not sure what the problem is. Could you give an example ? Maybe I can give you helping hand.

from whois.

rfc1036 avatar rfc1036 commented on July 21, 2024

Just query something with a / in it, e.g.:

whois --verbose 193.0.0.0/21

You will see that the / will be removed.

from whois.

rockdaboot avatar rockdaboot commented on July 21, 2024

That is a TR46 preprocessing thing. And you are right, if something is a domain or not (e.g. IP or network address) currently isn't handled by libidn2. So the application has to decide.
But we (at libidn2) would discuss to check for standard non-domains in the API. Please open an issue at https://gitlab.com/jas/libidn2/issues with a reference to this issue here.

Just for the record, the described behavior can be reproduced by:

$ idn2 -T 193.0.0.0/21
193.0.0.021

from whois.

andreasstieger avatar andreasstieger commented on July 21, 2024

So that do you think about #53? Tests fine for all my test cases.

from whois.

rockdaboot avatar rockdaboot commented on July 21, 2024

You got my 👍 (= looks good) 6 days ago.

from whois.

andreasstieger avatar andreasstieger commented on July 21, 2024

So indeed with libidn2 2.0.3 the problems are gone:

make clean; make all HAVE_LIBIDN2=1
./whois -h whois.ripe.net 193.0.0.0/21
./whois 2001:67c:2178:8::1

So neither d6e33ff nor 1e6a7b3 are required to fix CIDR notation queries, and the fix is in libidn2. So I think this can be closed.

from whois.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.