rfdj / simplenlg-nl Goto Github PK
View Code? Open in Web Editor NEWA Java-based surface realiser for Natural Language Generation in Dutch, based on SimpleNLG (https://github.com/simplenlg/simplenlg)
License: Other
A Java-based surface realiser for Natural Language Generation in Dutch, based on SimpleNLG (https://github.com/simplenlg/simplenlg)
License: Other
Describe the bug
When formulating an interrogative type and adding a postmodifier, this will not be added to the end of the sentence
To Reproduce
Steps to reproduce the behavior:
final private static Lexicon lexicon_nl = new simplenlg.lexicon.dutch.XMLLexicon();
final private static NLGFactory factory_nl = new NLGFactory(lexicon_nl);
final private static Realiser realiser_nl = new Realiser();
SPhraseSpec clause3 = factory_nl.createClause();
NPPhraseSpec subject = factory_nl.createNounPhrase("JIJ");
PPPhraseSpec aboutJan = factory_nl.createPrepositionPhrase("over","Jan");
subject.setFeature(Feature.PRONOMINAL, true);
subject.setFeature(Feature.PERSON, Person.SECOND);
clause3.setSubject(subject);
clause3.setVerb("denk");
clause3.addPostModifier(aboutJan);
clause3.setFeature(Feature.INTERROGATIVE_TYPE, InterrogativeType.WHAT_OBJECT);
String output3 = realiser_nl.realiseSentence(clause3);
System.out.println(output3);
Expected behavior
I added a fix for taking the right morphology for question types for Person.SECOND
, so the verb is denkt
most likely in other cases, though in the debug output, also the inflection might differ.
The expected output:
Wat denk jij over Jan?
The actual output:
Wat denk over Jan jij?
Java version
JDK 8 and JDK 13
Additional context
Debug output: link
Describe the bug
When creating an interrogative type question, the verb does not pick the correct form.
To Reproduce
Steps to reproduce the behavior:
Lexicon lexicon = new XMLLexicon();
NLGFactory nlg = new NLGFactory(lexicon);
Realiser realiser = new Realiser();
SPhraseSpec clause = nlg.createClause("you", "think");
PPPhraseSpec aboutJohn = nlg.createPrepositionPhrase("about", "John");
clause.addPostModifier(aboutJohn);
clause.setFeature(Feature.INTERROGATIVE_TYPE,InterrogativeType.WHAT_OBJECT);
String realisation = realiser.realiseSentence(clause);
The result is:
What does you think about John?
Expected behavior
The result should be:
What do you think about John?
Screenshots
If applicable, add screenshots to help explain your problem.
Java version
Tested with JDK 8 and 13.
Additional context
It seems that in the original SimpleNLG there is a test in which it selects the appropriate verb. See the method testWhatObjectInterrogative()
at line 814. The same goes for a Dutch sentence, configured like this:
Lexicon lexicon = new simplenlg.lexicon.dutch.XMLLexicon();
NLGFactory nlg = new NLGFactory(lexicon);
Realiser realiser = new Realiser();
SPhraseSpec phrase = nlg.createClause();
NPPhraseSpec subject = nlg.createNounPhrase("Jij");
subject.setFeature(Feature.PRONOMINAL, true);
subject.setFeature(Feature.PERSON, Person.SECOND);
phrase.setSubject(subject);
phrase.setVerb("doen");
phrase.setObject("dat");
phrase.setFeature(Feature.INTERROGATIVE_TYPE, InterrogativeType.WHY);
phrase.setFeature(Feature.TENSE, Tense.PRESENT);
String result = realiser.realiseSentence(phrase);
The result: Waarom doet jij dat?
, the expected result is Waarom doe jij dat?
For the What do you think about John?
sentence, the contents of the realization:
SimpleNLG NL:
{realisation=null, category=SENTENCE, features={interrogative=true, textComponents=[InflectedWordElement[what:NOUN], [InflectedWordElement[do:VERB]], [InflectedWordElement[you:PRONOUN]], [InflectedWordElement[think:VERB], [[InflectedWordElement[about:PREPOSITION], [InflectedWordElement[John:ANY]]]]]]}}
Debug: link
Original
{realisation=null, category=SENTENCE, features={interrogative=true, textComponents=[InflectedWordElement[what:PRONOUN], InflectedWordElement[do:VERB], InflectedWordElement[you:PRONOUN], [InflectedWordElement[think:VERB], [[InflectedWordElement[about:PREPOSITION], InflectedWordElement[John:ANY]]]]]}}
Debug: link
It could have to do with that What
is a pronoun in the one case, and a noun in the other case?
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.