rhinestonewtf / registry Goto Github PK
View Code? Open in Web Editor NEWAn Attestation Registry for securely using Smart Account Modules
Home Page: https://docs.rhinestone.wtf/
License: GNU General Public License v3.0
An Attestation Registry for securely using Smart Account Modules
Home Page: https://docs.rhinestone.wtf/
License: GNU General Public License v3.0
onlyResolver
may mean if it is checking the address is a resolver addressonlyOwner
onlyResolver
to isSupportedResolver
From SyncLinear.com | RHI-18
Following discussion with @leekt, we should add dynamic msg.value to create2
Following on from feedback by Ankur at Biconomy
Saw that these are not used
https://github.com/rhinestonewtf/registry/blob/main/test/AttestationDelegation.t.sol#L316-L328
the registry currently uses a boolean flag in attestations to allow for L2 propagations.
It would be better to implement a more complex whitelist, that allows attesters to either:
Ongoing security is so critical to the module ecosystem and the Registry that I can't think of any legitimate reason to want to have a Schema or Attestation be un-revocable.
At best, this flag would only waste gas, at worst it could lead to security issues where attestations on compromised modules cannot be revoked.
following to discussion with @shahafn
there are optimization opportunities how the registry is handling revocationTime
and revocable
in the attestation struct.
Not using the sender/owner to calculate the UID of Resolvers could lead to senders being frontrun and unable to register the Resolver because the UID is already taken - it could also lead to resolvers being owned by someone malicious without noticing and later changed (thanks to Lee Yu for pointing this out)
Requires discussion
From SyncLinear.com | RHI-19
we are currently deriving the schemaUID by calculating a hash on the schema string, the owner (wallet registering the schema) and if its revokable.
I am not sure if this is a good derivation path...
we need schemaIDs to be the same across chains to allow for propagation, and the schema need to be bound to the creator, or else someone could frontrun registration and block the schemaID.
the downside of the current derivation path is that it doesnt allow for wallet rotation for authorities in the future.
we could use the resolver address as a parameter in the hash derivation but that also makes things dangerous if some authorities choose to use create2 for their resolver and can be frontrun
https://github.com/rhinestonewtf/registry/blob/main/src/base/RSSchema.sol#L110-L121
The current ERC1271 checks only allow for r,s,v, signatures.
this breaks compatibility with multisigs or other signature schemas
https://github.com/rhinestonewtf/registry/blob/main/src/eip712/EIP712Verifier.sol#L217
Following on from discussions with @rmeissner on ERC-7484
Following feedback by @shahafn:
Query.sol checks should reference the expirationTime
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.