GithubHelp home page GithubHelp logo

Comments (7)

Vages avatar Vages commented on June 17, 2024 4

I found a fix. Will be posting a PR in a few minutes.

from electron-about-window.

Vages avatar Vages commented on June 17, 2024 2

Same here. Here's how it looks.

image

from electron-about-window.

Vages avatar Vages commented on June 17, 2024 2

While the PR is waiting to be merged, you can use patch-package and add the following file to your project's patches folder. Name the file about-window+1.12.1.patch (or change the version number if you're on some earlier version):

diff --git a/node_modules/about-window/src/index.js b/node_modules/about-window/src/index.js
index 6a3cb6f..7bc8545 100644
--- a/node_modules/about-window/src/index.js
+++ b/node_modules/about-window/src/index.js
@@ -100,6 +100,11 @@ function openAboutWindow(info_or_img_path) {
         titleBarStyle: 'hidden-inset',
         show: !info.adjust_window_size,
         icon: info.icon_path,
+        webPreferences: {
+            // For security reasons, nodeIntegration is no longer true by default when using Electron v5 or later
+            // nodeIntegration can be safely enabled as long as the window source is not remote
+            nodeIntegration: true,
+        },
     }, info.win_options || {});
     window = new (electron_1.BrowserWindow || electron_1.remote.BrowserWindow)(options);
     window.once('closed', () => {

from electron-about-window.

rhysd avatar rhysd commented on June 17, 2024 2

This issue was fixed by v1.13.0. Please update package.

from electron-about-window.

dtslvr avatar dtslvr commented on June 17, 2024 2

This issue was fixed by v1.13.0. Please update package.

Thanks a lot, @rhysd and @Vages!

from electron-about-window.

4rno avatar 4rno commented on June 17, 2024

Thanks @Vages ! On my side, I'm gonna use your fork repo while we wait your PR to be merged.

from electron-about-window.

4rno avatar 4rno commented on June 17, 2024

Actually, you can also use the win_options property when you call the openAboutWindow() function, and set nodeIntegration to true.

openAboutWindow({
    ...
    win_options: {
        webPreferences: {
            nodeIntegration: true
        }
    }
})

win_options | Options of 'About This App' window. It is merged into default options. Optional | BrowserWindow options object

from electron-about-window.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.