ribru17 / bamboo.nvim Goto Github PK

Hey, thanks for creating such a nice (and new) theme. Would you be opposed to having a separate colorscheme file for each of the variants? I often find myself wanting to quickly switch between different variants of a colorscheme, and being able to just use colo bamboo-vulgaris, colo bamboo-light, or colo bamboo-multiplex is a bit short than typing out lua require("bamboo").toggle(). If you're not opposed, I can create a PR later. If you'd prefer to keep it simple, just close this MR :)

I've noticed this since the dropbar commit because I had a little hack to copy the PmenuSel colours to CocMenuSel in my config:

function! UpdatePmenuSel()
  " Get the current colors of PmenuSel
  let pmenu_fg = synIDattr(hlID('PmenuSel'), 'fg#')
  let pmenu_bg = synIDattr(hlID('PmenuSel'), 'bg#')
  let pmenu_gui = synIDattr(hlID('PmenuSel'), 'gui')

  if empty(pmenu_fg)
    let pmenu_fg = 'NONE'
  endif

  if empty(pmenu_bg)
    let pmenu_bg = 'NONE'
  endif

  if empty(pmenu_gui)
    let pmenu_gui = 'NONE'
  endif

  " Build the highlight command
  let highlight_cmd = 'highlight CocMenuSel guifg=' . pmenu_fg . ' guibg=' . pmenu_bg . ' gui=' . pmenu_gui

  highlight_cmd
  echom highlight_cmd

  " Execute the highlight command
  execute highlight_cmd
endfunction

call UpdatePmenuSel()

autocmd ColorScheme * call UpdatePmenuSel()

Without the above the CoC menu-selection colours are invisible.

I do notice that your theme supports CoC, so perhaps I did something wrong myself? I accept this could be an issue elsewhere in my config.

Anyway, I really like the Bamboo theme, so thank you regardless of whether or not this issue is relevant.

Hello,

I noticed that there is no support for color highlights for nvim-notify. Would be nice to implement those to avoid unnecessary warnings for missing highlights.

Here's how kanagawa does it for reference.

Hi,

I like your theme, it is great.
So my question is how to change the border style (like width or color) when the window is split horizontally.

Thanks.

Hi @wez I was wondering if it would be possible to sync this theme with Wezterm if you ever get the chance? I added the necessary toml files in the extras/wezterm directory. I would've made a PR myself but I was a bit unfamiliar with the required process and I couldn't figure out if I just needed to call this repo in the sync_toml function or if some extra work was required. Hopefully this is not too much work, but if it is I will be glad to do it myself if pointed in the right direction. Thank you so much for your time!

Hello,

Thank you for the excellent colorscheme!

I was wondering if you'd be willing to incorporate a configuration parameter dim_inactive: bool to essential dim NormalNC windows/buffers. It's quite a good feature to add imo since it allows the user to focus on the currently active pane clearly.

For reference, here's kanagawa and nightfox.

Thanks!

Hello,

Perhaps it's just my config but it appears that code_style config block is not quite honored as expected. For example, here's my config:

return {
	"ribru17/bamboo.nvim",
	lazy = false,
	enabled = true,
	cond = true,
	priority = 1000,
	config = function()
		require("bamboo").setup({
			transparent = true,
			dim_inactive = true,
			term_colors = true,
			code_style = {
				comments = "none",
				conditionals = "none",
				keywords = "none",
				functions = "none",
				strings = "none",
				variables = "none",
			},
			lualine = {
				transparent = true,
			},
			highlights = {
				["@comment"] = { fg = "$grey" },
			},
		})
		vim.o.background = "dark"
		require("bamboo").load()
	end,
}

And notice the following (I haven't underlined everything but you get the idea):

Everywhere in the highlights.lua file comments seems to be c.grey. However, when defining @comment they are set to c.bg_yellow. Was this a mistake?

I attempted to overwrite this in the setup() doing this:

require('bamboo').setup {
  highlights =  {
   ['@comment'] = { fg = '$grey' },
  }
}

but I still get yellow comments...once semantic tokens come in from the language server. For now I've changed the code to c.grey in highlights.lua.

I like the theme, except for comments.

Can this be made into a VSCode theme? I love this color scheme and it would be great as a VSCode theme.

Not sure if this is the right place for this request…

I was wondering if you'd consider spending some time in improving the contrast for the light palette. I'll just post some screenshot here:

Notice the very light blue color here:

This is my personal opinion but the choice of light golden yellow for struct name/type value also seems faint:

Similarly (light orange, light golden yellow, very light blue) for imports:

You really don't have to do this, I just wanted to bring this to your attention since I truly appreciate your choice of colors for the dark palette the light one could also use some extra love :). Thanks!

Hi, when I turned on dim_inactive, the dimmed windows have different background color for text line and empty lines at the end of files.
It seems these lines are not dimmed.

Inactive win left, active win right.

Thanks for the excellent theme.

I searched for Tmux version but failed to find one.

Here is my noob attempt https://github.com/emilkm/bamboo-tmux