ric2016 / openstreetmap_hooked Goto Github PK

Switch between current display (places of individual and close relatives) and display of current individual's places only.

if only events from a single location are shown, we currently zoom in all the way, which is not very useful.

Set a sensible max zoom level for this case (and maybe make it available as a configuration option).

"The module doesn’t seem to locate places unless all components of the place name are present in the place hierarchy
For example, I have a location "Moordown, Buttermere, Wiltshire, England” but I’ve only entered the location data for "Buttermere, Wiltshire, England”. GoogleMaps seems to ignore the first component when this occurs"

i test your module openstreetmap

for 4 to 7 it's ok

Apparently shouldn't use fact->summary() directly (html entities, images), see screenshot:

Useful for users testing this module/ migrating from Google Maps module?

Mainly marriage is probably of interest here, but there is no good reason not to include all family events.

nl.csv.zip

on your tree i can see the list diagram possible.
but on my tree the bottom on the list are under the map
i use webtrees 1.7.16 in local with your last module version
theme webtrees
thanks to tell me why i have not as you as display and how i can correct this

see yours

see for me

This issue is with the Hooks module, which you obtain from a third party. You might therefor not be inclined to change the code for it, but you may want to document the behaviour I describe, and a workaround for it.

My webtrees (1.7.9) still uses MyISAM as database engine, since it was first installed as version 1.2.6.

On my localhost installation, I have even disabled InnoDB, because of other tools that work better with MyISAM. As a consequence, the ENGINE=InnoDB instruction in ./modules_v3/hooks_repackaged/Module/Hooks/Schema/Migration0.php is ignored, and in turn the MyISAM engine ignores the FOREIGN KEY instruction (reduces it to just another index). Therefor installing the Hooks module for openstreetmap_hooked runs fine on that localhost.

On my public webserver installation however, that also still uses the old MyISAM tables, I can not disable the InnoDB engine, and the maj_hooks table is in effect created as an InnoDB table. But a FOREIGN KEY restriction requires exact equality of the 2 keys involved, including the database engine for their respective tables. This causes an error when Migration0.php is first executed, from the module administration code :

SQLSTATE[HY000]: General error: 1005 Can't create table webtrees.webtr_maj_hooks (errno: 150 "Foreign key constraint is incorrectly formed")

Workaround
Replace the database engine in ./modules_v3/hooks_repackaged/Module/Hooks/Schema/Migration0.php with ENGINE=MyISAM