richardottinger / d3-create-json Goto Github PK

This is a great little json library. However, I found a bug.

In JSON.ARRAY.ADD.OBJECT, on line 3, you have: IF CURRENT < TOTAL

However...this doesn't take into account the case where you only have one item in the array. When you have only one item, then Current = Total, and you won't prepend the "[" to the array (which happens on line 4), because you don't get past the if condition on line 3 (since CURRENT = TOTAL when there is only 1 item in the array).

Instead, you want to have CURRENT <= TOTAL on line 3, and then enforce the CURRENT < TOTAL inside that if condition.

Here is how I refactored this and I think it works:

`SUBROUTINE JSON.ARRAY.ADD.OBJECT(CURRENT,TOTAL,JSON_OBJECT,JSON_ARRAY)

• DESCRIPTION: determines whether to PREPEND [, or APPEND a ], or append a comma to the JSON.OBJECT, then adds the current json object to the json array that is currently being built
  IF CURRENT <= TOTAL THEN
  IF CURRENT EQ 1 THEN CALL STRING.PREPEND('[',JSON_OBJECT) ;* same as JSON.OBJECT = '[' : JSON.OBJECT

  IF CURRENT < TOTAL THEN
  CALL STRING.APPEND(',',JSON_OBJECT)
  END ELSE ;* same as JSON.OBJECT := ','
  CALL STRING.APPEND(']',JSON_OBJECT)
  END
  END
  CALL STRING.APPEND(JSON_OBJECT,JSON_ARRAY) ;* same as thing as JSON.ARRAY := JSON.OBJECT
  RETURN`