richteague / disksurf Goto Github PK

Thanks for the nice package. 🎉

I am wondering if the following imports are really needed, as this package already requires python 3. 🤔

(openjournals/joss-reviews#3827)

In the get_emission_surface function, the velocity corresponding to each peak is specified with peaks += [[r, z, Fnu, self.velax[c_idx]]]. c_idx corresponds to the index of the cube corresponding to data = self.data.copy()[chans[0]:chans[1]+1]. However, self.velax corresponds to the velocities of the full image cube. Therefore, the incorrect velocities are returned if the chans argument is used to select a subset of channels.

On a minor related subject, the docstring says that chans should be a tuple, but chans needs to be a list or an array instead; the program will throw an error at the line chans[0], chans[1] = int(min(chans)), int(max(chans)) because tuples are immutable.

If you are interested in contributing, please submit a pull request. New functions should be documented in a manner consistent with existing code. Software bugs or mistakes in the documentation should be reported by opening up an issue. If reporting a software bug, please provide a minimal reproducible example. If your bug is triggered with a proprietary image cube,

Hello.

When attempting to import observation, I get an 'invalid syntax' error pointing to the * in " return rvals, *pcnts.T"
I am using py36.

I would be grateful for any guidance you might have.

Can we add some weighting options that allow us to include priors from different molecules? For example, saying 13CO must be below 12CO?