rick-2ca / cgmm Goto Github PK

SendAs permissions are not taken into account on either the on-premise object nor the synced cloud object. Those permissions are separate. The on-premise send-as permissions should be applied to the new on-premise contact. There should probably be an option to apply them to the new cloud distribution group along with whatever was already set in the cloud.

X400 addresses must follow a strict format that doesn't allow the configured prefix to be applied at the beginning of the address string. To attempt to work with that requirement code will be committed that puts a prefix on the 'surname' portion (S=) of X400 addresses.

This solution obviously only works if the address has a surname configured. I'm not certain at this point if it'll be a widespread issue or not. If this is a thing please comment with your environment's scenario so we may explore changes.

Never defined $SessionName in the import functions. Consider defining it or removing it. It's not impacting the module.

The Convert-CGMMStagingMailContact function does multiple calls to both Get-MailContact and Set-MailContact. Only one of the calls uses the DomainController parameter. This impacts interaction with the mail contact if a different domain controller is used for each step by Exchange.

Use Get-Group to determine if the DL is a member of another group. A common scenario is to create groups in Exchange Online with an unsynced contact in Exchange on-premise. CGMM will make the contact a memberof an on-premise group, but that doesn't help on the online side. Most environments should benefit from migrating parent groups before nested groups. This test should make that relationship apparent.