rickosborne / cfdiff Goto Github PK

Need at least a minimal amount of documentation for the SVN browser.

1. How to install
2. How to configure

What steps will reproduce the problem?

1. When the time to process the data is 0 ms the following error occures:
Error Occurred While Processing Request 
Division by zero. 

row: <cfset Times.x_Factor[i]=Round(t1/t2)&"x">

2. Possible solution
<cftry><cfset Times.x_Factor[i]=Round(t1/t2)&"x"><cfcatch 
type="any"><cfset Times.x_Factor[i]="n/a"></cfcatch></cftry>

At least some documentation would be nice.

1. How to install
2. How to use
3. What could be optimized

Img tag in svn.cfm (DiffGraphic variable) has two 'width' arguments, and no
height argument.

I have attached a patch file for this.

The testDiffArraysNoChange fails, with this message:
   Recordcount does not match: expected:<0> but was:<1> 

What steps will reproduce the problem?
  1. Get the latest version of the application from SVN
  2. Browse to the testdiff http://localhost/cfdiff/testdiff.cfm
  3. The failure is displayed

I took a quick look, and I am not positive, but it looks like maybe this line:
   <cfset assertEquals("Recordcount does not match",0,Q.RecordCount)>
should maybe be:
   <cfset assertEquals("Recordcount does not match",0,Q.count)>
(using the count, instead of the recordcount)

If that is the case, I've attached a patch file with this solution.

What steps will reproduce the problem?
1. Try to compare  ListToArray("a,b,c,d,e,f,g,h,i,j,k,l,m,n,o,p,q") 
2. and ListToArray("i").
3. The error occurs when using both UnifiedDiffArrays() and Parallelize()

What is the expected output? What do you see instead?
I get an error "The element at position 0 of array variable "DOWNVECTOR"
cannot be found." in diff.cfc: line 495 ( cfset DownVector[DownOffset+k]=x ).

What version of the product are you using? On what operating system?
I'm using the diff.cfc available for download today (Nov 19, 2007)

SVNBrowser does not support the svn protocol, it currently only supports
http. So if the URL to my repository is "svn://servername" instead of
"http://servername" I am unable to use the svnbrowser.

I have a possible solution to this, I will attatch the patch file. 

Do we want to implement a version of the algorithm as a plain-old CFM
template for cfmodule uses?  Are enough people still on 4.x or 5.x that
would use this?

The SVN browser is horrifically bade code.  It should be refactored to use
MVC, or at least something a bit less spaghetti-like.  Do we want plugins
for specific frameworks?

Need to figure out how we want to implement this.  Is it row-based?  Is it
cell-based?

Presumably, we want to be able to diff only a certain subset of columns.

A very common use case is to have side-by-side output, à la MediaWiki
diffs. Rendering this into HTML and providing default styles would be very
helpful. It's something I might be able to contribute a patch for, if
desired. See, for example:

http://www.shlomygantz.com/blog/index.cfm/2005/11/3/Diff-cfc-A-ColdFusion-diff-c
omponent

The current diff algorithm, while pleasantly easy to understand, is very
very naive and very very slow.  We need to implement an algorithm that
isn't O(n^2) and won't chew up memory and processor.