ringgaard / sanos Goto Github PK

Hi,
thanks for the good work.

I am unsure if this is the right place to report bugs in "edit", I found nothing better; please redirect me as needed.

I found a small (but show-stopping) error in the Linux implementation:

  struct termios tio;
  struct termios orig_tio;
  ...
  tcgetattr(0, &orig_tio);
  cfmakeraw(&tio);  
  tcsetattr(0, TCSANOW, &tio);

should be:

  struct termios tio;
  struct termios orig_tio;
  ...
  tcgetattr(0, &orig_tio);
  tio = orig_tio;                   // <-- this line is missing
  cfmakeraw(&tio);  
  tcsetattr(0, TCSANOW, &tio);

otherwise struct termios tio is not correctly initialized and bad things happen, especially so if the underlying terminal is a serial line.

RTEMS (RTEMS.org) is a free single process, multi-threaded real-time operating system with a long history. Your cool editor (edit.c) has been incorporated into RTEMS as one of the shell commands available. The RTEMS Project is a member of the Coverity Scan program and it flagged an issue in this file. In trying to be good citizens of the wider open source community, the project wants these issues to be reported to the upstream owner along with a fix or suggestions. This is one of those reports.

When Coverity Scan was ran on some of your code, a "Unchecked return value" error was found at line 1050 in src/utils/edit/edit.c. For similar errors that we received for RTEMS, we created a macro that will assert the value returned and "use" the return value like so.

int status;

status = get_selection(ed, &selstart, &selend);
assert(status == 0);
(void)status;

You can just use "(void)get_selection()" if you don't care to check the return value of the function call at all, but this is just a suggestion.

-when i try 1.3.4 version dir works, fdisk works, created hda0 ~128MB (current build does the same, but dir command desnt works)
setup says error:
Formatting device hd10a (blocksize=4096, cache1024) ...
Error 5 (Input/output error) performing format
Installation failed

Thanks for building the Sanos text editor!

I really like the design principles behind the Sanos text editor, and I'm considering using it as a jumping off point for creating an editor designed to meet my needs. In particular, I love the idea of sticking with the principle of least surprise, but I'd like to add some features that make the Sanos editor a bit easier to integrate into my development process, which is basically the Unix as an IDE paradigm.

In particular, I'm considering implementing the following:

• Command line argument processing for internal commands.
  • edit -l 20 edit.c would open the editor with the cursor on line 20 of edit.c. This makes it quicker to jump to compiler errors.
  • edit -f find_text edit.c would open the editor and jump to the first occurrence of the string "find_text" in the file edit.c.
• Consider the current line to be the current selection when nothing is selected.
  • This makes it a bit quicker to copy/cut/paste single lines, which is a common operation. I don't envision this causing much confusion given that the operations have no meaning when used without a selection currently.
• Ctrl+D to duplicate the current selection. This is very simple, and I've submitted a PR for this one.
• Remove Crtl+G as find_next. Modify Ctrl+F to find_next if there is text currently selected. Basically, Ctrl+F becomes find the next occurrence of the current selection or find as it is currently if nothing is selected.
• Bind Ctrl+G as goto line in addition to Ctrl+L (this matches Sublime and some other editors)
• Implement search in project/directory and basic search by symbol (i.e. Sublime's Goto Anything). This is a relatively large feature and for such a lean editor might actually double the size of the code base.

I see that there haven't been any commits to this project in years, but I wanted to check to see if you'd be interested in having any of the above merged at some point or if you have suggestions for changes that you would want merged. There's no hard feelings either way. I completely understand if you just want to keep this as lean as possible.

using current build
sanos-bin-latest.zip, sanos-qemu.zip
after boot up:

/$ dir
error: No such file or directory

cd /mnt doesnt works too, no visible files, directories ...

it would be nice to add script to build bootable CD IMAGE, floppy is problem, we can add RTL8139, we can set HDD to legacy mode, but se cant add floppy controller, im not 100% sure if usb floppy allways works