Comments (4)
I'm on board with the idea. My only criticism is you can do all of this
if (m_ui->widgetFind->isVisible())
{
widgetFind->findChild<QLineEdit*>("lineEditSearch")->setFocus();
}
with this
m_ui->lineEditSearch->setFocus();
If you want to make a pull request, I'll merge it. If not I can do it myself.
from memento.
I'd certainly make a fixed PR. The only thing is whether you want the same thing to be done for SearchWidget, which I feel is also more complex after a bit of poking.
from memento.
Doing the same for SearchWidget is not any more complex than this one. I would say that if you did choose to include SearchWidget, make the change in a separate commit and move the implementation for showEvent
into the cpp
file.
from memento.
Better yet, you can just connect the widgetShown
signal to setFocus
and leave showEvent
where it is.
from memento.
Related Issues (20)
- MacOS - Please ensure your Linux system has 64 bit binary support HOT 3
- Script doesn't work when launching memento but works from command line HOT 6
- Cannot create card from sentences with <> between them HOT 2
- Size and quality options for Anki screenshots. HOT 8
- Bad Video Playback Performance (on Mac) HOT 7
- Fails to populate {audio-media} HOT 8
- Memento cannot tell if a word is in your deck if added externally HOT 4
- Changing font size for secondary subtitle track HOT 1
- Keep session and autoplay last played video HOT 6
- Other languages HOT 2
- Unpause video when cursor is away from subtitles HOT 4
- Duplicate card logic has false positives with pure hiragana words
- Modifier keys don't behave correctly on macOS HOT 3
- Sometimes fails to populate {audio-media}
- Looking up Bug HOT 1
- [ytdl_hook] ERROR: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug HOT 8
- Inconsistent ability to add Anki notes HOT 8
- there is build error when compiling , please help. HOT 2
- Search Within Subtitle List HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from memento.